Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt api.ScreenOrientation.onchange to new events structure #15197

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Adapt api.ScreenOrientation.onchange to new events structure #15197

merged 2 commits into from
Mar 16, 2022

Conversation

queengooborg
Copy link
Contributor

This PR adapts the change event of the ScreenOrientation API to conform to the new events structure.

@queengooborg
Adapt api.ScreenOrientation.onchange to new events structure
54c00e6 
This PR adapts the change event of the ScreenOrientation API to conform to the new events structure.
@queengooborg queengooborg added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Mar 1, 2022
@queengooborg queengooborg mentioned this pull request Mar 1, 2022
Closed
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Mar 16, 2022
@queengooborg
Copy link
Contributor Author

Removing the "needs content update" label because the related page is a stub and is getting removed.

Elchi3
Elchi3 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an event that ought to be documented, but okay, maybe work for another day.

@Elchi3 Elchi3 merged commit 5854617 into mdn:main Mar 16, 2022
@queengooborg queengooborg deleted the api/ScreenOrientation/change/events branch March 16, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @Elchi3