-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a guideline for setting deprecated
#15703
Conversation
(I figure that Ruth and Philip aren't really required for a review here, but I've tagged them as a courtesy.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! I just have some wording and formatting suggestions, feel free to decline any that don't seem reasonable!
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Cool cool - in which case approved from me once @queengooborg has :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Summary
This provides some guidance on how to set the
deprecated
status, despite its somewhat misleading name.Test results and supporting details
I've been tidying up my branches and came across this thing. I think it mostly documents our existing practice, so hopefully this will be an uncontroversial addition to the data guidelines.