Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a guideline for setting deprecated #15703

Merged
merged 6 commits into from
Apr 13, 2022

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Apr 7, 2022

Summary

This provides some guidance on how to set the deprecated status, despite its somewhat misleading name.

Test results and supporting details

I've been tidying up my branches and came across this thing. I think it mostly documents our existing practice, so hopefully this will be an uncontroversial addition to the data guidelines.

@github-actions github-actions bot added the docs ✍️ Issues or pull requests regarding the documentation of this project. label Apr 7, 2022
@ddbeck
Copy link
Collaborator Author

ddbeck commented Apr 7, 2022

(I figure that Ruth and Philip aren't really required for a review here, but I've tagged them as a courtesy.)

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! I just have some wording and formatting suggestions, feel free to decline any that don't seem reasonable!

docs/data-guidelines.md Outdated Show resolved Hide resolved
docs/data-guidelines.md Outdated Show resolved Hide resolved
docs/data-guidelines.md Outdated Show resolved Hide resolved
@Rumyra
Copy link
Collaborator

Rumyra commented Apr 12, 2022

Cool cool - in which case approved from me once @queengooborg has :D

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM!

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@ddbeck ddbeck merged commit dc2b646 into mdn:main Apr 13, 2022
@ddbeck ddbeck deleted the deprecated-is-discouraged branch April 13, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs ✍️ Issues or pull requests regarding the documentation of this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants