Fix Chrome/Edge versions for showNotification's options.actions parameter #16261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
foolip
commented
May 12, 2022
| }, | ||
| "edge": { | ||
| "version_added": "≤79" | ||
| "version_added": "18" |
There was a problem hiding this comment.
This matches maxActions which I also tested in Edge 17/18 using https://mdn-bcd-collector.appspot.com/tests/api/Notification/maxActions to confirm it was added in Edge 18.
Since we don't have the source we can't be certain they were added together, but it's very likely I would say.
…eter Original source: mdn#1255 However, both the orignally suggested 47 and the updated 45 are wrong, and no evidence is given for either version. This was enabled together with Notifications.maxActions in 48: https://storage.googleapis.com/chromium-find-releases-static/2a3.html#2a381fb7a46742b05d199c6614624b1bf1432ebb We can also confirm 48 is correct with this test: https://mdn-bcd-collector.appspot.com/tests/api/Notification/maxActions
queengooborg
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original source: #1255
However, both the orignally suggested 47 and the updated 45 are wrong,
and no evidence is given for either version.
This was enabled together with Notifications.maxActions in 48:
https://storage.googleapis.com/chromium-find-releases-static/2a3.html#2a381fb7a46742b05d199c6614624b1bf1432ebb
We can also confirm 48 is correct with this test:
https://mdn-bcd-collector.appspot.com/tests/api/Notification/maxActions