Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api.GlobalEventHandlers.onabort #16514

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR demixes the abort global event and separates them into their own interfaces.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 2, 2022
@foolip
Copy link
Collaborator

foolip commented Jun 2, 2022

These are the event targets for "abort" events I can find in Chromium:

  • XMLHttpRequest
  • XMLHttpRequestUpload
  • IDBTransaction
  • SourceBuffer
  • AbortSignal
  • FileReader
  • HTMLMediaElement
  • FileWriter

These all have "abort_event" entries in BCD except FileWriter, which isn't in BCD.

onabort was on GlobalEventHandlers only because of HTMLMediaElement, so I don't think there's anything to add, we should just remove the entry, not add anything new.

@queengooborg queengooborg changed the title Demix abort global event Remove api.GlobalEventHandlers.onabort Jun 2, 2022
@foolip
Copy link
Collaborator

foolip commented Jun 2, 2022

Not merging in case content updates are needed for this.

@queengooborg queengooborg added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jun 2, 2022
@queengooborg queengooborg merged commit c722520 into mdn:main Jun 3, 2022
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jun 3, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/abort branch June 9, 2022 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants