Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove durationchange event from GlobalEventHandlers #16558

Merged
merged 4 commits into from
Jun 21, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR demixes the durationchange event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 5, 2022
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a media element event, I'd like to ask for the same changes/checks as in #16541 (review).

@queengooborg queengooborg added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jun 13, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

1 similar comment
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've compared to the "durationchange_event" entry on HTMLMediaElement and that data is earlier than this.

@foolip foolip changed the title Demix durationchange event from GlobalEventHandlers Remove durationchange event from GlobalEventHandlers Jun 21, 2022
@foolip foolip merged commit 9ea04a1 into mdn:main Jun 21, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/durationchange branch June 21, 2022 14:28
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants