Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove play/playing/pause events from GlobalEventHandlers #16673

Merged
merged 4 commits into from
Jun 22, 2022

Conversation

queengooborg
Copy link
Contributor

This PR demixes the play, playing and pause events from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 14, 2022
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 15, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

1 similar comment
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are HTMLMediaElement events, can you revert the additions?

@foolip foolip merged commit ff17c7c into mdn:main Jun 22, 2022
@foolip foolip changed the title Demix play/playing/pause events from GlobalEventHandlers Remove play/playing/pause events from GlobalEventHandlers Jun 22, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/playpause branch June 22, 2022 07:10
@Elchi3 Elchi3 removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants