Fix Identifier type #16685
Merged
Fix Identifier type #16685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
bershanskiy
reviewed
Jun 15, 2022
bershanskiy
reviewed
Jun 15, 2022
index.test.ts
Outdated
|
|
||
| describe('Using BCD', () => { | ||
| it('subscript notation', () => { | ||
| const data: CompatStatement = bcd['api']['AbortController']['__compat']; |
There was a problem hiding this comment.
warning 'data' is assigned a value but never used
The easiest way to fix this is not to declare the variable:
it('subscript notation', () => {
bcd['api']['AbortController']['__compat'];
});
Similarly on line 14.
There was a problem hiding this comment.
The purpose of the variable was to ensure that the types match. I've added an assert.ok() call so this check can still be utilized!
There was a problem hiding this comment.
Ah, I see, yes that makes more sense!
saschanaz
added a commit
to saschanaz/browser-compat-data
that referenced
this pull request
Jun 16, 2022
Interestingly this does not make anything fail?
queengooborg
added a commit
that referenced
this pull request
Jun 17, 2022
* Verify types.d.ts after generation * Revert the schema change from #16685 Interestingly this does not make anything fail? Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
Identifiertype to ensure the BCD data can be converted to the TypeScript types.