Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ratechange event from GlobalEventHandlers #16721

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Remove ratechange event from GlobalEventHandlers #16721

merged 2 commits into from
Jun 21, 2022

Conversation

queengooborg
Copy link
Contributor

This PR demixes the ratechange event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 18, 2022
@queengooborg queengooborg mentioned this pull request Jun 18, 2022
Closed
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 18, 2022
foolip
foolip requested changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please trim this down to just the removal, the "ratechange_event" entry on HTMLMediaElement is all we should have here.

@foolip foolip changed the title Demix ratechange event from GlobalEventHandlers Remove ratechange event from GlobalEventHandlers Jun 21, 2022
@foolip foolip merged commit 141492c into mdn:main Jun 21, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/ratechange branch June 21, 2022 19:08
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 21, 2022
@queengooborg
Copy link
Contributor Author

Looks like no content updates were needed for this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @foolip