Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reset event from GlobalEventHandlers #16722

Merged
merged 9 commits into from
Jul 7, 2022
Merged

Remove reset event from GlobalEventHandlers #16722

merged 9 commits into from
Jul 7, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR demixes the reset event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 18, 2022
@queengooborg queengooborg added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jun 18, 2022
@queengooborg queengooborg mentioned this pull request Jun 19, 2022
Closed
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

foolip
foolip requested changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at Chromium source there are resets events fired for HTMLFormElement and XRReferenceSpace, and BCD already has both. Can you revert the additions?

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@foolip foolip changed the title Demix reset event from GlobalEventHandlers Remove reset event from GlobalEventHandlers Jul 7, 2022
foolip
foolip approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted the additions now.

@queengooborg queengooborg mentioned this pull request Jul 7, 2022
Merged
@queengooborg queengooborg merged commit 5fcea8d into mdn:main Jul 7, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/reset branch July 9, 2022 10:13
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @foolip