Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demix scroll event from GlobalEventHandlers #16727

Merged
merged 11 commits into from
Jul 14, 2022

Conversation

queengooborg
Copy link
Contributor

This PR demixes the scroll event from the GlobalEventHandlers mixin.

@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 19, 2022
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 19, 2022
api/Window.json Outdated Show resolved Hide resolved
api/HTMLElement.json Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@@ -6951,7 +6951,10 @@
"__compat": {
"description": "<code>scroll</code> event",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Document/scroll_event",
"spec_url": "https://drafts.csswg.org/cssom-view/#eventdef-document-scroll",
"spec_url": [
"https://drafts.csswg.org/cssom-view/#eventdef-document-scroll",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the Element entry with the same URLs? This one is actually the one for elements too, despite "document" in the fragment.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the same 2 or 3 URLs for both entries. I'd suggest just keeping 2, https://drafts.csswg.org/cssom-view/#scrolling-events is a section about multiple events.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 14, 2022
@queengooborg queengooborg merged commit ad90fb7 into mdn:main Jul 14, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/scroll branch July 14, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants