adding compat data for Character Data #1732
Conversation
Elchi3
added
the
data:api
api/CharacterData.json
Outdated
| }, | ||
| "chrome": { | ||
| "version_added": "1" | ||
| }, |
There was a problem hiding this comment.
chrome_android is missing. Make sure it's present throughout.
api/CharacterData.json
Outdated
| "description": "Implements <a href='https://developer.mozilla.org//docs/Web/API/ChildNode'><code>ChildNode</code></a> Interface", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": null |
There was a problem hiding this comment.
true for all 3 flavors of Chrome and both of Opera.
| @@ -0,0 +1,92 @@ | |||
| { | |||
| "api": { | |||
| "CharacterData": { | |||
There was a problem hiding this comment.
The following sub-features are missing (see DOM Standard):
appendDatadatadeleteDatainsertDatalengthreplaceDatasubstringData
Since MDN doesn't have any compat data for these sub-features yet, we can set all browsers mentioned in this feature to null. I would also suggest adding mdn_urls, even if the sub-articles don't exist yet.
|
Made the changes requested |
api/CharacterData.json
Outdated
| "version_added": true | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Sorry, I just noticed that status information are missing, both for the feature and each sub-feature. The information can be derived from the Specifications section on MDN.
Since the DOM Standard doesn't mention the ChildNode interface, this sub-feature should be probably marked "standard_track": false" and everything else "standard_track": true".
|
Ah, you're right, I forgot that, I'll get right on it. Thanks!
|
|
Added the statuses |
There was a problem hiding this comment.
Thanks for this PR, @katzrkool! And thank you for the prior reviews, @caugner! The only thing blocking this from being merged is to sort the browsers in the "support" blocks alphabetically. Thank you!
|
Made requested changes |
|
Thank you, @katzrkool! 🎉 |
No description provided.