Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fetchpriority to match final spec #18944

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Conversation

pmeenan
Copy link
Contributor

@pmeenan pmeenan commented Feb 17, 2023

Summary

This updates the fetchpriority HTML attribute and priority fetch option to match the final spec. 1fetchprioritywas removed from the iFrame element andpriority` is no longer available on the Request object (it is part of the init config dictionary but that doesn't appear to have compat-level data).

Test results and supporting details

Here is the HTML spec PR and the Fetch spec PR.

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML labels Feb 17, 2023
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the links are LGTM! However, we set experimental status in BCD based upon browser implementation, not spec implementation -- because this feature set is only supported in Chrome, experimental should be set back to true.

@pmeenan
Copy link
Contributor Author

pmeenan commented Feb 18, 2023

@queengooborg Thanks. I assume by "browser" you mean the underlying engine, right? It has been enabled in all Chromium-based browsers for the better part of the last year.

I flipped it back to experimental and can come back and toggle it again when the Gecko or WebKit implementations reach a stable browser (both are in-flight).

Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes, LGTM!

@queengooborg queengooborg merged commit 693f6ed into mdn:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants