-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compat data for EventType #1899
Conversation
api/EventType.json
Outdated
"support": { | ||
"webview_android": { | ||
"version_added": null | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api/EventType.json
Outdated
"support": { | ||
"webview_android": { | ||
"version_added": null | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
I have changed to alphanumeric order |
api/EventType.json
Outdated
}, | ||
"click": { | ||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Events/click", | ||
"support": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contents of click
must be also contained inside a __compat
block, that’s why the build is failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
api/EventType.json
Outdated
}, | ||
"click": { | ||
"__compat": { | ||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Events/click", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL should be https://developer.mozilla.org/docs/Web/Events/click
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
api/EventType.json
Outdated
"standard_track": true, | ||
"deprecated": false | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
click
should have a sub-feature called on_disabled_elements
containing the following:
"on_disabled_elements": {
"__compat": {
"description": "On disabled form elements",
"support": {
"chrome": {
"version_added": true,
"partial_implementation": true,
"notes": "Only works for <code><textarea></code> elements and some <code><input></code> element types."
},
"chrome_android": {
"version_added": null
},
"edge": {
"version_added": false
},
"edge_mobile": {
"version_added": false
},
"firefox": {
"version_added": false
},
"firefox_android": {
"version_added": false
},
"ie": {
"version_added": true,
"partial_implementation": true,
"notes": "Internet Explorer only triggers the <code>click</code> event on <code><input></code> elements of type <code>checkbox</code> or <code>radio</code> when the element is double-clicked."
},
"opera": {
"version_added": true,
"partial_implementation": true,
"notes": "Only works for <code><textarea></code> elements and some <code><input></code> element types."
},
"opera_android": {
"version_added": null
},
"safari": {
"version_added": null
},
"safari_ios": {
"version_added": null
},
"samsunginternet_android": {
"version_added": null
},
"webview_android": {
"version_added": null
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why will I add this to the click
event, is not sub-feature of click
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It must be on the same level as the __compat
block, but not inside the __compat
block.
Also, stuff like this has been made into sub-features in the past:
browser-compat-data/api/NavigatorConcurrentHardware.json
Lines 52 to 56 in 5133d14
}, | |
"available_on_workers": { | |
"__compat": { | |
"description": "Available on Workers", | |
"support": { |
browser-compat-data/html/elements/html.json
Lines 110 to 114 in 0fd82d0
}, | |
"secure_context_required": { | |
"__compat": { | |
"description": "Secure context required (HTTPS)", | |
"support": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I understand but why add it? This is not an event.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it’s part of the current documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thank you I had not understood the why of how. Thank you. I will add it.
Thanks for your work! I thought this was about an "EventType" API. It isn't however. We have not yet decided how to structure compat data from MDN event pages. See the discussion in #935. I will come back to this PR once that is sorted. Sorry for any inconveniences. |
No problem, take your time. the pull request does not move. |
We've started re-doing event pages and mouse events are reworked as part of this task: mdn/sprints#955 I'm closing here now as we won't add this data the way this PR suggests. |
https://developer.mozilla.org/en-US/docs/Web/Events/click