Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat data for EventType #1899

Closed
wants to merge 8 commits into from
Closed

Conversation

hichxm
Copy link

@hichxm hichxm commented Apr 23, 2018

@hichxm hichxm changed the title add api.EventType.click Add compat data for EventType Apr 23, 2018
@Elchi3 Elchi3 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Apr 23, 2018
"support": {
"webview_android": {
"version_added": null
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put webview_android to the end of the support block? (see issue #398 and #1882)

"support": {
"webview_android": {
"version_added": null
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@hichxm
Copy link
Author

hichxm commented Apr 23, 2018

I have changed to alphanumeric order

},
"click": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Events/click",
"support": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents of click must be also contained inside a __compat block, that’s why the build is failing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

},
"click": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Events/click",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

"standard_track": true,
"deprecated": false
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

click should have a sub-feature called on_disabled_elements containing the following:

"on_disabled_elements": {
  "__compat": {
    "description": "On disabled form elements",
    "support": {
      "chrome": {
        "version_added": true,
        "partial_implementation": true,
        "notes": "Only works for <code>&lt;textarea&gt;</code> elements and some <code>&lt;input&gt;</code> element types."
      },
      "chrome_android": {
        "version_added": null
      },
      "edge": {
        "version_added": false
      },
      "edge_mobile": {
        "version_added": false
      },
      "firefox": {
        "version_added": false
      },
      "firefox_android": {
        "version_added": false
      },
      "ie": {
        "version_added": true,
        "partial_implementation": true,
        "notes": "Internet Explorer only triggers the <code>click</code> event on <code>&lt;input&gt;</code> elements of type <code>checkbox</code> or <code>radio</code> when the element is double-clicked."
      },
      "opera": {
        "version_added": true,
        "partial_implementation": true,
        "notes": "Only works for <code>&lt;textarea&gt;</code> elements and some <code>&lt;input&gt;</code> element types."
      },
      "opera_android": {
        "version_added": null
      },
      "safari": {
        "version_added": null
      },
      "safari_ios": {
        "version_added": null
      },
      "samsunginternet_android": {
        "version_added": null
      },
      "webview_android": {
        "version_added": null
      }
    },
    "status": {
      "experimental": false,
      "standard_track": true,
      "deprecated": false
    }
  }
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why will I add this to the click event, is not sub-feature of click?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be on the same level as the __compat block, but not inside the __compat block.

Also, stuff like this has been made into sub-features in the past:

},
"available_on_workers": {
"__compat": {
"description": "Available on Workers",
"support": {
},
"secure_context_required": {
"__compat": {
"description": "Secure context required (HTTPS)",
"support": {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I understand but why add it? This is not an event.

Copy link
Contributor

@ExE-Boss ExE-Boss Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it’s part of the current documentation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you I had not understood the why of how. Thank you. I will add it.

@Elchi3 Elchi3 added not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. and removed data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API labels Apr 26, 2018
@Elchi3
Copy link
Member

Elchi3 commented Apr 26, 2018

Thanks for your work! I thought this was about an "EventType" API. It isn't however.

We have not yet decided how to structure compat data from MDN event pages. See the discussion in #935. I will come back to this PR once that is sorted. Sorry for any inconveniences.

@hichxm
Copy link
Author

hichxm commented Apr 26, 2018

No problem, take your time. the pull request does not move.

@Elchi3
Copy link
Member

Elchi3 commented Feb 27, 2019

We've started re-doing event pages and mouse events are reworked as part of this task: mdn/sprints#955
The compat data will be submitted to this repo as part of that work as well. The page is already moved to a new place https://developer.mozilla.org/en-US/docs/Web/API/Element/click_event

I'm closing here now as we won't add this data the way this PR suggests.

@Elchi3 Elchi3 closed this Feb 27, 2019
@Elchi3 Elchi3 added invalid Invalid issues or pull requests (wrong repo, spam, duplicates, etc.). This won't get merged. Sorry! and removed not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. labels Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Invalid issues or pull requests (wrong repo, spam, duplicates, etc.). This won't get merged. Sorry!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants