-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FF113 supports WebGPU on nightly #19370
Conversation
@@ -50,9 +54,13 @@ | |||
}, | |||
"edge": "mirror", | |||
"firefox": { | |||
"version_added": "preview", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This count
and type
are in a dictionary GPUQuerySetDescriptor
, and it is not so obvious these become properties of GPUQuerySet. Question is, if these are properties, why is pipelineStatistics
not present - should it be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are you getting pipelineStatistics
from? I can't see it in the editor's draft anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisdavidmills It's probably not. To work out what is implemented and not I've been working through the FF WebIDL: https://searchfox.org/mozilla-central/source/dom/webidl/WebGPU.webidl
Confusingly this is close, but not the same as the spec IDL. So you get oddities like inheritance of errors not being the same, and so on. If it isn't in the spec it might just be useful for Mozilla, or it might reflect and older spec. I linked to the bugzilla bug above with some questions, and I hope the developers will comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, cool. I checked through the Chromium IDL, and it's not in there either.
Thanks @Elchi3 - I've updated all the A few things though
|
@hamishwillee I don't think this would be very helpful anyway. The spec has changed quite a bit since then. |
Should I be doing that for Chrome? |
If chrome didn't implement all the interfaces then realistically I think you'd want to add a serializable subfeature to track what is and is not supported. But I am not sure whether it should be added to the ones that do support the feature or do not, or both! We need advice from @Elchi3 or @queengooborg |
Hi @Elchi3 , @chrisdavidmills I've done some more research/testing today and update this appropriately. It is now as far as I can tell accurate and ready for review. Note however that it may not yet be complete w.r.t. behaviour features. Even so I would prefer we merged this and then added the behaviours as a follow on - OK? |
This has not been my practice. There are many interfaces in BCD that don't have I opened openwebdocs/project#146 how to record security information in the front-matter as I don't want the BCD project to become a general sink for all kinds of data. It does a good job for compatibility data but I think general data should live more closely to the content (or should come from the specs via webref directly). (Same for workers, but there isn't just one type of workers and someone should write up a proposal how to systematically record worker information analog to my security proposal, but let's maybe get one thing done, learn, and then do more of this)
Yes. |
I'm not quite sure I have the context here. Happy to review data and work on a guideline as a followup. Do you have pointers for me? |
@Elchi3 2. W.r.t. secure_context, fair enough.
So a serializable object is one that you can send in a postMessage or use in a structured clone. The list of things to which it applies is provided in Structured clone algorithm > Supported types. When I added Errors to that list, I also made sure their descriptions mentioned this feature (but did not add to others): The data rule is the same as for secure content - you add it if there is a compatibility change. That was the case for the errors - see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/EvalError#browser_compatibility Is that enough? MDN docs side I think we probably should add metadata for serializable, secure context, etc by default and use icons or whatever to indicate these "features". |
@Elchi3 I removed the bugzilla link (agree not useful). Serialization has not been implemented on anything yet as far as we can tell, so there is nothing to record there. Secure context has been implemented as far as we can tell so compatibility issue to record. Upshot, I think this is good and ready to go in. Can you review/merge? |
Thanks Hamish! This all sounds great to me. Thanks for the info on serialization. Would be nice to formalize this in a guideline (on both BCD and MDN). How it is done for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
FF113 supports WebGPU on nightly in https://bugzilla.mozilla.org/show_bug.cgi?id=1746245
Spec has iterated a lots since this was defined. Probably not worth tracking introduction of various parts behind pref. This just tracks broad WebGPU support as Preview.
Open questions on devs here: https://bugzilla.mozilla.org/show_bug.cgi?id=1746245#c21
Other docs work can be tracked in mdn/content#26157
List is what is documented and in BCD. X indicates also in WebIdl for FF. So this is check of coverage.
dispatchWorkgroupsIndirect
onSubmittedWorkDone()
drawIndirect()
,drawIndexedIndirect()
.beginOcclusionQuery
,endOcclusionQuery
,beginPipelineStatisticsQuery
,endPipelineStatisticsQuery()
,writeTimestamp()
. Also behind pref isdrawIndirect()
,drawIndexedIndirect()
.message
is shown as in IDL for FF (not inherited) but as inherited in spec.A few issues: