Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RTCIceServer API from BCD #19577

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Apr 28, 2023

This PR removes the RTCIceServer API from BCD. This feature is a type (ex. a dictionary, enum, mixin, constant or WebIDL typedef) that we have explicitly stated not to document separately from the feature(s) that depend on it, as they are virtually invisible to the end developer.

Additional Notes: I'd love for someone to take on the content changes if possible, but if nobody is interested I'd be happy to give the content updates a shot!

This PR removes the `RTCIceServer` API from BCD. This feature is a type (ex. a dictionary, enum, mixin, constant or WebIDL typedef) that we have explicitly stated not to document separately from the feature(s) that depend on it, as they are virtually invisible to the end developer.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/RTCIceServer

Additional Notes: I'd love for someone to take on the content changes if possible, but if nobody is interested I'd be happy to give the content updates a shot!
@queengooborg queengooborg added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Apr 28, 2023
@queengooborg queengooborg added the project: dictionary removal https://github.com/mdn/browser-compat-data/issues/6810 label Jun 26, 2023
Copy link
Contributor

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@hamishwillee hamishwillee merged commit c23248a into mdn:main Nov 6, 2023
@queengooborg queengooborg deleted the api/RTCIceServer/removal branch November 6, 2023 02:39
@Elchi3 Elchi3 removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Nov 6, 2023
Elchi3 pushed a commit to Elchi3/browser-compat-data that referenced this pull request Nov 14, 2023
* Remove RTCIceServer API from BCD

This PR removes the `RTCIceServer` API from BCD. This feature is a type (ex. a dictionary, enum, mixin, constant or WebIDL typedef) that we have explicitly stated not to document separately from the feature(s) that depend on it, as they are virtually invisible to the end developer.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/RTCIceServer

Additional Notes: I'd love for someone to take on the content changes if possible, but if nobody is interested I'd be happy to give the content updates a shot!

* Fix consistency

* Add descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API project: dictionary removal https://github.com/mdn/browser-compat-data/issues/6810
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants