Change MDN page for chrome support of AnimationEvent.pseudoElement #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
added
the
data:api
ExE-Boss
reviewed
May 7, 2018
| @@ -338,13 +338,13 @@ | |||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/AnimationEvent/pseudoElement", | |||
| "support": { | |||
| "webview_android": { | |||
| "version_added": false | |||
| "version_added": "68" | |||
There was a problem hiding this comment.
Should I move webview_android only for the 'pseudoElement', or everything in this file?
There was a problem hiding this comment.
I think the plan is to alphabetize everything once the PR queue has been gone-through, so you don't need to worry about that for now.
|
LGTM 👍 |
Elchi3
approved these changes
May 22, 2018
There was a problem hiding this comment.
LGTM as well, thanks!
You might want to update https://www.chromestatus.com/features/5112855204462592 as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AnimationEvent.pseudoElement is implemented and shipped in chromium here:
https://chromium-review.googlesource.com/c/chromium/src/+/1019383
It will hit chrome stable in M68. This updates the MDN page.
@birtles @flackr