Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data for cross-document view transitions features #22638

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

chrisdavidmills
Copy link
Collaborator

@chrisdavidmills chrisdavidmills commented Mar 15, 2024

Summary

Chrome 123/124 includes features required for developers to create cross-document View Transitions. This includes:

This PR adds/updates the BCD for all of these.

Related ChromeStatus entries:

Test results and supporting details

Related issues

@github-actions github-actions bot added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML labels Mar 15, 2024
@captainbrosset
Copy link
Contributor

I know this is a stretch, and don't want to derail you from your work here but if, by any chance, you know the bug URLs for implementing cross-document view transitions in Firefox and in Safari, it would be awesome to add them as impl_url fields next to version_added:false for those browsers.

@chrisdavidmills
Copy link
Collaborator Author

I know this is a stretch, and don't want to derail you from your work here but if, by any chance, you know the bug URLs for implementing cross-document view transitions in Firefox and in Safari, it would be awesome to add them as impl_url fields next to version_added:false for those browsers.

I don't, I'm afraid ;-)

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why the collector says unsupported for the viewTransition properties.
https://mdn-bcd-collector.gooborg.com/tests/api/PageRevealEvent
https://mdn-bcd-collector.gooborg.com/tests/api/PageSwapEvent

I bet you've written some code that uses the property and saw it working, though?

LGTM otherwise, just one tag that was added accidentally.

css/at-rules/view-transition.json Outdated Show resolved Hide resolved
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@chrisdavidmills
Copy link
Collaborator Author

I wonder why the collector says unsupported for the viewTransition properties. https://mdn-bcd-collector.gooborg.com/tests/api/PageRevealEvent https://mdn-bcd-collector.gooborg.com/tests/api/PageSwapEvent

I bet you've written some code that uses the property and saw it working, though?

LGTM otherwise, just one tag that was added accidentally.

Ah yes, some of the features are still hidden behind the "viewTransition API for navigations" Chrome flag; the versions I've added in are the ones they'll be enabled for in those cases.

Sorry, forgot to mention that.

@Elchi3
Copy link
Member

Elchi3 commented Mar 26, 2024

Ah yes, some of the features are still hidden behind the "viewTransition API for navigations" Chrome flag; the versions I've added in are the ones they'll be enabled for in those cases.

okay, in this case I think we need to mark them behind a flag for now.

@chrisdavidmills
Copy link
Collaborator Author

Ah yes, some of the features are still hidden behind the "viewTransition API for navigations" Chrome flag; the versions I've added in are the ones they'll be enabled for in those cases.

okay, in this case I think we need to mark them behind a flag for now.

@Elchi3 OK, done

@Elchi3
Copy link
Member

Elchi3 commented Apr 16, 2024

Looks good to me for PageSwapEvent but what about:

  • api.PageRevealEvent.PageRevealEvent
  • api.PageRevealEvent.viewTransition

These show up unsupported in Chrome 124 for me in https://mdn-bcd-collector.gooborg.com/tests/api/PageRevealEvent

@chrisdavidmills
Copy link
Collaborator Author

Looks good to me for PageSwapEvent but what about:

* api.PageRevealEvent.PageRevealEvent

* api.PageRevealEvent.viewTransition

These show up unsupported in Chrome 124 for me in https://mdn-bcd-collector.gooborg.com/tests/api/PageRevealEvent

Flag information added to these too. I've definitely tested them as working with the flag enabled.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris!

If these interfaces are behind a flag, I'm skeptical about the availability of pageswap_event and pagereveal_event on Window but I think we should land this PR for now and correct the data if needed later on (hopefully we will soon have a version number for unflagged support and then the flags will disappear anyways).

Note: I'm always happy to review early BCD entries for flagged features, but as you can see, work is required to sort things out properly. So, if it is not absolutely pressing, I would wait until things are shipping properly and only then submit BCD (or have it submitted by the collector).

@Elchi3 Elchi3 merged commit ef25c98 into mdn:main Apr 24, 2024
6 checks passed
@chrisdavidmills chrisdavidmills deleted the cross-document-view-transitions branch April 24, 2024 10:09
@chrisdavidmills
Copy link
Collaborator Author

Thanks Chris!

If these interfaces are behind a flag, I'm skeptical about the availability of pageswap_event and pagereveal_event on Window but I think we should land this PR for now and correct the data if needed later on (hopefully we will soon have a version number for unflagged support and then the flags will disappear anyways).

Yup, this is what I was hoping for; also, it will be a little while until we get the docs reviewed anyway, and by then I'm hoping it will be out from behind the flag.

Note: I'm always happy to review early BCD entries for flagged features, but as you can see, work is required to sort things out properly. So, if it is not absolutely pressing, I would wait until things are shipping properly and only then submit BCD (or have it submitted by the collector).

Yeah, I totally understand the reasoning here. Usually I am a bit further behind the curve than this, but I do get a few work items that are high priority and therefore they want me to get done earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants