Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 17/23 added webextensions.api.webRequest support #24280

Merged

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Sep 3, 2024

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the webRequest Web Extensions interface. The data comes from a commit in the browser's source code, mapped to a version number using available tooling or via the commit timestamp.

Commits:

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `webRequest` Web Extensions interface. The data comes from a commit in the browser's source code, mapped to a version number using available tooling or via the commit timestamp.

Commit: https://source.chromium.org/chromium/chromium/src/+/da1430bbf5853abb6dc4886812ab3e9a133664f3, https://source.chromium.org/chromium/chromium/src/+/85231d73b03552f369a32ce640189c531e42cf96
@queengooborg queengooborg added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Sep 3, 2024
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 18, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 18, 2024
@queengooborg queengooborg requested a review from caugner November 19, 2024 03:33
@github-actions github-actions bot added the size:s [PR only] 7-24 LoC changed label Nov 20, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on chromium/chromium@da1430b, I would say that this landed in Chrome 17.

This is in 17.0.956.0, and the release was 17.0.963.0 based on web search.

@caugner
Copy link
Contributor

caugner commented Nov 20, 2024

The commit message suggests that the corresponding permission landed at the same time:

"chrome": {
"version_added": "≤64",
"notes": "In Manifest V3, no longer available for most extensions (the exception being policy-installed extensions). Use the `declarativeNetRequest` API instead."
},

See also the corresponding optional_permission, for which we have set version 18 in 2e3ff5d. 🤔

"webRequest": {
"__compat": {
"support": {
"chrome": {
"version_added": "18"
},

webextensions/api/webRequest.json Outdated Show resolved Hide resolved
@caugner caugner changed the title Update Chromium data for webRequest Web Extensions interface Chrome 17/23 added webextensions.api.webRequest support Nov 27, 2024
@caugner caugner enabled auto-merge (squash) November 27, 2024 11:54
@caugner caugner merged commit 67c8713 into mdn:main Nov 27, 2024
7 checks passed
@queengooborg queengooborg deleted the webextensions/api/webRequest/chrome-corrections branch November 27, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions size:s [PR only] 7-24 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants