Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 4 added webextensions.api.bookmarks.onCreated support #24313

Conversation

queengooborg
Copy link
Contributor

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the onCreated member of the bookmarks Web Extensions interface. The data comes from a commit in the browser's source code, mapped to a version number using available tooling or via the commit timestamp.

Commit: https://source.chromium.org/chromium/chromium/src/+/5592d7ec9c8b63cca9ab980d4c2d9888dafc3761

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `onCreated` member of the `bookmarks` Web Extensions interface. The data comes from a commit in the browser's source code, mapped to a version number using available tooling or via the commit timestamp.

Commit: https://source.chromium.org/chromium/chromium/src/+/5592d7ec9c8b63cca9ab980d4c2d9888dafc3761
@queengooborg queengooborg added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Sep 4, 2024
@github-actions github-actions bot added the size:xs [PR only] 0-6 LoC changed label Nov 22, 2024
@@ -339,7 +339,7 @@
"mdn_url": "https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/bookmarks/onCreated",
"support": {
"chrome": {
"version_added": "≤58"
"version_added": "4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium/chromium@5592d7e in 4.0.212.1 before 4.0.223.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, the feature landed before as onAdded, but only after Chrome 3.

@caugner caugner changed the title Update Chromium data for webextensions.api.bookmarks.onCreated Chrome 4 added webextensions.api.bookmarks.onCreated support Nov 22, 2024
@caugner caugner merged commit 2a5abac into mdn:main Nov 22, 2024
7 checks passed
@queengooborg queengooborg deleted the webextensions/api/bookmarks/onCreated/chrome-corrections branch November 22, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions size:xs [PR only] 0-6 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants