Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate css.types.basic-shape.path and descendants #24502

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Sep 24, 2024

Summary

css.types.basic-shape.path is shown as partially implemented in all browsers, but this information is a summation of the descendant features. This PR undoes this flattening, showing path() support commencing with the first of the subfeatures.

Test results and supporting details

Since this is duplicate information, the source is BCD itself (i.e., css.types.basic-shape.path.{clip-path,d,offset-path,shape-outside}), though I'm just deleting data rather than introducing new facts.

The existing structure of this data—with subfeatures reiterating a partial implementation of the parent—makes actually consuming this data in web-features impossible. Because the parent feature is shown as not implemented and compute-baseline follows a feature's ancestry (e.g., to know if a feature is behind its parent's prefix), the descendants are also treated as partially implemented. Since there's a way to know which contexts are supported—the features dedicated to those facts—I think we shouldn't show partially implemented on the top-most path() feature.

Related issues

web-platform-dx/web-features#1799

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Sep 24, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes much more sense this way.

@caugner caugner merged commit 934442a into mdn:main Oct 2, 2024
5 checks passed
@ddbeck ddbeck deleted the path-uncluttering branch October 2, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants