Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data version of NavigateEvent.canTransition #24792

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

skyclouds2001
Copy link
Contributor

Summary

this property is never removed from chromium implement, though the property is non-standard and deprecated

between M102 and M104, only canTransition is supported; M105+, both canTransition and canIntercept are supported, and the two property are the same

this is updated in #18105

but note that the property still existed in source code, and it has changed to be an alias for canIntercept in chromium/chromium@d53817e, which is landed in M105

Test results and supporting details

check chromium source and observe in lates stable chrome

Related issues

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 22, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review October 22, 2024 17:34
@skyclouds2001
Copy link
Contributor Author

maybe an alternative_name field for canIntercept is better?

api/NavigateEvent.json Outdated Show resolved Hide resolved
@skyclouds2001 skyclouds2001 requested a review from caugner October 25, 2024 14:29
@caugner caugner merged commit 07cb361 into mdn:main Oct 25, 2024
6 checks passed
@skyclouds2001 skyclouds2001 deleted the NavigateEvent.canTransition branch October 25, 2024 17:24
@caugner caugner mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants