Ensure that some browsers are only allowed in specific categories #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
evilpie
reviewed
Jul 18, 2018
ddbeck
added
the
linter
|
I think this is no longer relevant now. In #3160 we've seen that node implements some features in api/ land and so that validation isn't really useful anymore. For the other edge case browsers, we have decided to not add them to the repo. I could imagine to test for webextension-only browsers, but I'm not sure if it is really neeeded. What do you think, @ExE-Boss ? |
|
I think it might be useful. |
Elchi3
requested changes
Jan 8, 2019
ExE-Boss
force-pushed
the
linter/test-browsers
branch
2 times, most recently
from
fec9edc to
683e8c5
Compare
|
The way I understand it, the goal for MDN is to only display Node in the |
3 tasks
Elchi3
requested changes
Jan 9, 2019
Elchi3
approved these changes
Jan 10, 2019
Elchi3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been suggested by @connorshea in #2332 (comment), and I agree that it’s a good idea, as it ensures that contributors don’t try to add
firefox_iosorthunderbirdto non‑WebExtension entries, ornodejsto non‑JavaScript entries (which it turns out they already did).It also ensures that PRs like #2484 get better error messages.
review?(@a2sheppy, @Elchi3)