Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs data for Blob #24886

Merged
merged 14 commits into from
Dec 17, 2024
Merged

Update nodejs data for Blob #24886

merged 14 commits into from
Dec 17, 2024

Conversation

skyclouds2001
Copy link
Contributor

Summary

https://nodejs.org/api/globals.html#class-blob
https://nodejs.org/api/buffer.html#class-blob

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 30, 2024
@github-actions github-actions bot added the data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. label Oct 30, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review October 30, 2024 19:50
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just one question.

api/Blob.json Outdated Show resolved Hide resolved
api/Blob.json Show resolved Hide resolved
Copy link

github-actions bot commented Nov 4, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 4, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 5, 2024
api/Blob.json Outdated Show resolved Hide resolved
caugner
caugner previously requested changes Nov 5, 2024
api/Blob.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@skyclouds2001 skyclouds2001 changed the title Update nodejs data for Blob interface Update nodejs data for Blob Nov 5, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 5, 2024
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
@skyclouds2001 skyclouds2001 requested a review from caugner November 5, 2024 16:21
Copy link

github-actions bot commented Nov 5, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 5, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 7, 2024
browsers/nodejs.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 12, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 12, 2024
@caugner caugner added the nodejs Data about Node.js label Nov 12, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 18, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 18, 2024
@github-actions github-actions bot added the size:l [PR only] 101-1000 LoC changed label Nov 21, 2024
api/Blob.json Outdated Show resolved Hide resolved
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
@queengooborg queengooborg merged commit 74ece0b into mdn:main Dec 17, 2024
9 checks passed
@mdn-bot mdn-bot mentioned this pull request Dec 17, 2024
@skyclouds2001 skyclouds2001 deleted the nodejs-blob branch December 17, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. nodejs Data about Node.js size:l [PR only] 101-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants