Fix & update nodejs data for Performance interface
#25007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
skyclouds2001
commented
Nov 11, 2024
caugner
reviewed
Nov 12, 2024
| }, | ||
| { | ||
| "version_added": "8.5.0", | ||
| "partial_implementation": true, | ||
| "notes": "Exported from the <code>perf_hooks</code> module" | ||
| "notes": "Only available as an internal instance." |
There was a problem hiding this comment.
How could users interact with this interface, if it wasn't exported prior to 18.8.0?
There was a problem hiding this comment.
though the interface can't be accessed directly, but it can be accessed via performance property: require('perf_hooks').performance.__proto__.constructor
performance.__proto__.constructor === Performance will report true in latest node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the exact version of when the
Performanceclass is exposed to global is not mentioned (only mentioned theperformanceglobal property)in node v19.0.0, while other performance related features has been exposed via nodejs/node#44483, the
Performanceinterface has been exposed yet;in node v16.0.0, only
performanceglobal proeprty is exposed to global via nodejs/node#37970;in node v18.8.0, here the
Performanceinterface is exposed to global via nodejs/node#44220, before this version, it is only available as an internal instance.Test results and supporting details
https://nodejs.org/docs/latest/api/globals.html#performance
https://nodejs.org/docs/latest/api/perf_hooks.html#perf_hooksperformance
Related issues