Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spec_url & update nodejs data for import.meta.resolve #25020

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 10, 2024

Summary

the feature is unflagged in https://nodejs.org/en/blog/release/v20.6.0 and fixed return value issue in https://nodejs.org/en/blog/release/v20.8.0, then both backlog to https://nodejs.org/en/blog/release/v18.19.0

nodejs/node#49028
nodejs/node#49698

Test results and supporting details

Related issues

Fixes #24054

@github-actions github-actions bot added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Nov 10, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 10, 2024 16:10
@caugner caugner added the nodejs Data about Node.js label Nov 12, 2024
@github-actions github-actions bot added the data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. label Nov 13, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🎉

@caugner caugner changed the title Fixes #24054 | Update nodejs data for import.meta.resolve Fix spec_url & update nodejs data for import.meta.resolve Nov 15, 2024
@caugner caugner merged commit bd1ae82 into mdn:main Nov 15, 2024
6 checks passed
@skyclouds2001 skyclouds2001 deleted the node-import.meta.resolve branch November 15, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript nodejs Data about Node.js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

javascript.operators.import_meta.resolve - latest Node also returns a string
3 participants