Move SVG attributes stop-color and stop-opacity to global attributes
#25272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:svg
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
caugner
changed the title
stop-color,stop-opacity as global attributesstop-color and stop-opacity to global attributes
caugner
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
LGTM.
Requesting a second opinion from @Elchi3 to double-check (this seems to be in alignment with #9462 (comment) though).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
stop-color,stop-opacityare also presentation attributes and so they'd better present in global attributes (as they apply to all elements)also including a move of
paint-orderglobal attributeTest results and supporting details
Related issues