Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 1 supported background-position: bottom/center/left/right/top #25283

Conversation

queengooborg
Copy link
Contributor

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the background-position CSS property. The data comes from the mdn-bcd-collector project (v10.12.7).

Check out the collector's guide on how to review this PR.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/background-position

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `background-position` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.12.7).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/background-position
@queengooborg queengooborg added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Dec 1, 2024
@github-actions github-actions bot added the size:s [PR only] 7-24 LoC changed label Dec 1, 2024
Elchi3
Elchi3 previously requested changes Dec 2, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even "Side-relative values (such as bottom 10% right 20%)" was supported in version 25 already. I think it is safe to set all these to version 1; they are foundational for this property.

@queengooborg
Copy link
Contributor Author

I had actually hunted down these particular version numbers through testing using the collector!

@caugner
Copy link
Contributor

caugner commented Dec 3, 2024

Even "Side-relative values (such as bottom 10% right 20%)" was supported in version 25 already.

What makes you think this was already supported in Chrome 25, and not only in Chrome 28?

@Elchi3
Copy link
Member

Elchi3 commented Dec 4, 2024

What makes you think this was already supported in Chrome 25, and not only in Chrome 28?

See the table https://developer.mozilla.org/en-US/docs/Web/CSS/background-position#browser_compatibility or the side-relative_values data in this file.

css/properties/background-position.json Outdated Show resolved Hide resolved
@caugner
Copy link
Contributor

caugner commented Dec 5, 2024

@queengooborg While we're here, let's also set Safari to <=4:

image

@caugner
Copy link
Contributor

caugner commented Dec 6, 2024

I tested in Chromium 2.0.165.0 locally using this dev build (predating the 2.0.172 release) from here via CrossOver:

image

I guess it's fair to assume support for bottom/center/left/right/top landed in Chromium 1!

@caugner
Copy link
Contributor

caugner commented Dec 6, 2024

Confirmed working in Chrome 1.0.154.59:

image

@caugner caugner changed the title Update Chromium data for background-position CSS property Chrome 1 supported background-position: bottom/center/left/right/top Dec 6, 2024
@caugner caugner dismissed Elchi3’s stale review December 6, 2024 10:54

Changes addressed.

@caugner caugner merged commit 8cb3cf8 into mdn:main Dec 6, 2024
9 checks passed
@queengooborg queengooborg deleted the css/properties/background-position/chrome-corrections branch December 6, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:s [PR only] 7-24 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants