-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove css.types.color.color-contrast
#25305
Conversation
Can you elaborate on the spec changes? Is there a particular spec PR? If the changes are small, then I could imagine that it makes sense to track it as a partial implementation with an alternative name. |
Digging a bit deeper has made it less clear- apologies. Essentially, the current implementation with Spec changesIn Level 5, the function takes a single color and an optional keyword In Level 6, the function takes a color, an optional list of candidate colors, an optional yet-to-be-determined keyword for foreground or background, and an optional contrast algorithm. There is a resolution on this issue to include an MVP in Level 5, and then full functionality in Level 6. There is an issue to add Level 5 syntax to Level 6 syntax. Current implementationI incorrectly thought there was Chrome implementation. The Safari implementation uses a Given this, what makes the most sense for this key? |
Based on this, it would make sense to me to remove the Requesting a second opinion from @Elchi3. |
I agree with @caugner let's remove it altogether since it is essentially "spec-fiction" and not real. |
color-contrast
, mark as non-standard trackcss.types.color.color-contrast
Sounds good to me. @caugner I've removed |
Summary
The
color-contrast()
CSS function is no longer part of CSS Color Module Level 6. It was renamed tocontrast-color()
, and the spec has changed since Safari and Chrome did their experimental implementations.There's a few layers to this decision (renaming an experimental feature and changing the functionality), but my thought is that the cleanest would be to view
color-contrast()
andcontrast-color()
as separate types, meaning:color-contrast
tostandard_track: false
color-contrast
spec link (it links to the spec forconstrast-color
)contrast-color
once there is implementation.I'm open to other ideas as well.