Chrome 108/109 added webextensions.api.action.isEnabled/{get,set}BadgeTextColor
#25321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:webext
caugner
requested changes
Dec 6, 2024
There was a problem hiding this comment.
Thanks for updating this data.
I found slightly different versions by looking at this blame and copying the corresponding commit hash into Chromium Dash, see below.
As for adding UserSettingsChanged and onUserSettingsChanged, I do think it makes sense to add these, but open a separate PR for those, and wait for a second opinion from @rebloor before.
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
caugner
changed the title
webextensions.api.action.isEnabled/{get,set}BadgeTextColor
caugner
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per https://developer.chrome.com/docs/extensions/reference/api/action#method-setBadgeTextColor、https://developer.chrome.com/docs/extensions/reference/api/action#method-getBadgeTextColor、https://developer.chrome.com/docs/extensions/reference/api/action#method-isEnabled
fixes #25348
also note that chrome.action have new members not included in BCD yet:
UserSettingsChanged、onUserSettingsChangedadded in Chrome 130; should they also be included in BCD?