Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 127 fully supports webextensions.api.action.openPopup #25376

Closed
wants to merge 4 commits into from

Conversation

PassionPenguin
Copy link
Contributor

-                "notes": "Is only available to policy installed extensions and dev builds (e.g., Canary)."
+                "notes": "Is only available to policy installed extensions and dev builds (e.g., Canary) between Chrome 118 and Chrome 126."

FYI:

  1. https://developer.chrome.com/docs/extensions/reference/api/action#method-openPopup,
  2. chromium/chromium@c04d438

image

@github-actions github-actions bot added data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions size:xs [PR only] 0-6 LoC changed labels Dec 11, 2024
@@ -466,7 +466,7 @@
"support": {
"chrome": {
"version_added": "118",
"notes": "Is only available to policy installed extensions and dev builds (e.g., Canary)."
"notes": "Is only available to policy installed extensions and dev builds (e.g., Canary) between Chrome 118 and Chrome 126."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do two things here:

  1. Shorten the note as follows.
  2. Ideally split this up into two support statements:
    • A partial_implementation 118-127 with this note.
    • A full implementation from 127.
Suggested change
"notes": "Is only available to policy installed extensions and dev builds (e.g., Canary) between Chrome 118 and Chrome 126."
"notes": "Before Chrome 127, it is only available to policy installed extensions."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've update it to split the desc into 2 parts, as I think it will be a little bit more clear? :)

@github-actions github-actions bot added size:s [PR only] 7-24 LoC changed and removed size:xs [PR only] 0-6 LoC changed labels Dec 12, 2024
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Dec 13, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@caugner
Copy link
Contributor

caugner commented Dec 13, 2024

Apologies, I merged #25399, which made the same changes.

@caugner caugner closed this Dec 13, 2024
@PassionPenguin PassionPenguin deleted the patch-1 branch December 13, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. size:s [PR only] 7-24 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants