Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror Safari iOS for MessagePort worker support #25407

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

autonome
Copy link
Contributor

Summary

It's likely that iOS should mirror desktop here, but need to verify.

Test results and supporting details

Can't find anything in release notes yet.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 13, 2024
@github-actions github-actions bot added the size:xs [PR only] 0-6 LoC changed label Dec 13, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if @queengooborg might have come across evidence to intentionally set Safari iOS to 5 in this commit.

Otherwise MessagePort was implemented in WebKit/WebKit@42ae99f, i.e. 533.9 before Safari Desktop 5 (533.16), and technically also before Safari iOS 4.2 (533.17), which explains the support statement of the parent feature.

The commit message mentions this:

Added a MessagePort implementation. Currently, it is not thread-safe at all, and only works with Documents as contexts, but in the future, it will be used for communication with worker threads.

But I found WebKit/WebKit@e573a5a mentioning "Implement Worker messaging" and WebKit/WebKit@5dcde16 mentioning "support for multi-threaded MessagePorts" in the same WebKit version.

So it's plausible that worker support landed in Safari 5 and Safari iOS 4.2.

@caugner
Copy link
Contributor

caugner commented Dec 13, 2024

Looking at https://developer.mozilla.org/en-US/docs/Web/API/Worker#browser_compatibility, it might be that worker support only landed in Safari on iOS 5, and not yet in Safari 4.2. Or that version is wrong as well.

Edit: The original data for Worker support was added in f09df1e (with Safari in iOS 5.1), but the PR seems to be based on the MDN page at the time that indicated these versions, and does not provide further evidence.

Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems plausible to me. I think that when I had updated this info before, I made a mistake with the version numbers!

@queengooborg queengooborg merged commit 34eb165 into mdn:main Dec 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:xs [PR only] 0-6 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants