Enforce browser order in compatibility tables [MERGE #2889 FIRST] #2890
Conversation
|
I already do this in #1882. |
| @@ -2,6 +2,26 @@ | |||
| const fs = require('fs'); | |||
| const path = require('path'); | |||
|
|
|||
| function orderSupportBlock(name, val) { | |||
| if (name == 'support') { | |||
There was a problem hiding this comment.
support, eg. test.support:
"test": {
"support": {
"property": {},
"method": {}
}
}would be made invalid, whereas:
"test": {
"other": {
"property": {},
"method": {}
}
}would remain valid.
| @@ -245,4 +245,4 @@ | |||
| } | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Please, stop breaking the last newline.
There was a problem hiding this comment.
I honestly don't know why the newline keeps trying to get removed. It might be the JSON editor I'm using (which is out of date anyways). :/
| @@ -2,6 +2,26 @@ | |||
| const fs = require('fs'); | |||
| const path = require('path'); | |||
|
|
|||
| function orderSupportBlock(name, val) { | |||
| if (name == 'support') { | |||
There was a problem hiding this comment.
Also, wrong indentation.
|
Ah, I didn't see that you had combined the test and data updates into one PR, my bad, @ExE-Boss -- looking closer into your changes, it seems that you have a better function than what was written in #1474 (which I literally just copied and pasted, since the test and the data updates were merged into one commit, thus requiring a rebase which created the possibility of old data replacing the new). Since you're marking the other PR (with the actual data updates) as a dependency for your PR, perhaps you'd be up for reverting the changes to the data files and only keeping the test script updates, effectively maintaining the same structure as this PR, or merging our efforts into one single PR? |
|
I plan on reverting the data change commit and only keeping the test case update commit (and leaving the data update for #2889). |
|
Sounds good! |
queengooborg
added
duplicate
This PR is intended to enforce an alphabetical order in
__compat.support, as originally proposed by #1474. Fixes #398, closes #1474. This is one of two PRs that supersedes #1474, whereas the other one (#2889) sorts the browser compatibility order.NOTE: The Travis test will fail until #2889 is merged.
Warning: make sure to merge #2889 first before merging this one, else Travis tests will always fail.
Warning: Existing PRs will need to be updated to adhere to this new rule.