Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add descriptions to schema properties. #2923

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Add descriptions to schema properties. #2923

merged 2 commits into from
Oct 5, 2018

Conversation

connorshea
Copy link
Contributor

@connorshea connorshea commented Oct 4, 2018 •
edited
Loading

Resolves #309. I based most of the descriptions off the respective sections in the schema.md files.

@Elchi3 Elchi3 added the schema Isses or pull requests regarding the JSON schema files used in this project. label Oct 5, 2018
Elchi3
Elchi3 approved these changes Oct 5, 2018
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! 👍

@Elchi3 Elchi3 merged commit 5c10e0c into mdn:master Oct 5, 2018
@connorshea connorshea deleted the schema-descriptions branch October 5, 2018 16:44
@ExE-Boss ExE-Boss mentioned this pull request May 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
schema Isses or pull requests regarding the JSON schema files used in this project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connorshea @Elchi3