-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compat data for PromiseRejectionEvent #3007
Update compat data for PromiseRejectionEvent #3007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TrevorBurnham, thank you for this PR and welcome to BCD. A few changes to suggest on this one—we can get the data accuracy a little better I think—but this is a great start. Thank you again!
@ddbeck OK, I think I've addressed all of your feedback. Regarding |
@TrevorBurnham, welcome to BCD and thank you for doing this. FYI, caniuse and Chrome Status are fine as sources if you don't have anything better. Be aware that they are second-hand sources. Here's a search result on the commit hash from a Chromium system called Omaha Proxy. The link on that result takes you to the actual commit where the feature landed. I got the commit hash from the IDL's file history |
OK, them I'm going to go with 11.4 as the |
Feedback fixed; new review needed for browser changes
@Elchi3 would you mind reviewing the browser change here? I don't feel confident about reviewing |
hm, I have no idea whether or not these are versions that we would care about, or just minor updates without feature changes. Does anyone have Safari release notes handy? We need to find out which of the 11.x releases are major releases with web platform feature changes. Caniuse seems to have some grouping: |
This is also related to #2006. |
0f84926
to
354f11f
Compare
@vinyldarkscratch Per your comment, I've changed the iOS version specified here from Let me know if any other changes are needed here. |
354f11f
to
8ae6aeb
Compare
Awesome, thanks for the update, and thank you for the updates! Since this no longer makes any changes to the browsers, I think that this is ready. @ddbeck Since you know much more about this PR than I do (and the PR looks great to me), want to give it one final review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much, @TrevorBurnham! This was one of the longer-lived PRs in BCD, so I really appreciate your patience on this. Let's merge this! 🎉
Follow-up for #2100
Currently, the MDN docs indicate that
PromiseRejectionEvent
and the associatedwindow.onunhandledrejection
andwindow.onrejectionhandled
properties are Chrome-only. I believe the CanIUse data for these events are correct: https://caniuse.com/#feat=unhandledrejectionAlso, I believe this same data should appear on https://developer.mozilla.org/en-US/docs/Web/Events/unhandledrejection#Browser_compatibility.