Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(browsers): Add pref_url for feature flags page #3407

Merged
merged 3 commits into from
Feb 13, 2019
Merged

feat(browsers): Add pref_url for feature flags page #3407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77b7463
feat(browsers): Add `pref_url` for feature flags page
ExE-Boss Feb 6, 2019
b14fad8
Fix typo in `browsers‑schema.md`
Elchi3 Feb 12, 2019
6c54579
Update schemas/browsers.schema.json
Elchi3 Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions browsers/chrome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"browsers": {
"chrome": {
"name": "Chrome",
"pref_url": "chrome://flags",
"releases": {
"1": {
"release_date": "2008-12-11",
Expand Down
1 change: 1 addition & 0 deletions browsers/chrome_android.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"browsers": {
"chrome_android": {
"name": "Chrome Android",
"pref_url": "chrome://flags",
"releases": {
"18": {
"release_date": "2012-06-27",
Expand Down
1 change: 1 addition & 0 deletions browsers/edge.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"browsers": {
"edge": {
"name": "Edge",
"pref_url": "about:flags",
"releases": {
"12": {
"release_date": "2015-07-28",
Expand Down
1 change: 1 addition & 0 deletions browsers/edge_mobile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"browsers": {
"edge_mobile": {
"name": "Edge Mobile",
"pref_url": "about:flags",
"releases": {
"12": {
"release_date": "2015-07-15",
Expand Down
1 change: 1 addition & 0 deletions browsers/firefox.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"browsers": {
"firefox": {
"name": "Firefox",
"pref_url": "about:config",
"releases": {
"1": {
"release_date": "2004-11-09",
Expand Down
1 change: 1 addition & 0 deletions browsers/firefox_android.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"browsers": {
"firefox_android": {
"name": "Firefox Android",
"pref_url": "about:config",
"releases": {
"4": {
"release_date": "2011-03-29",
Expand Down
7 changes: 6 additions & 1 deletion schemas/browsers-schema.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ The file `firefox.json` is structured like this:
"browsers": {
"firefox": {
"name": "Firefox",
"pref_url": "about:config",
"releases": {
"1.5": {
"release_date": "2005-11-29",
Expand All @@ -35,7 +36,11 @@ Underneath, there is a `releases` object which will hold the various releases of

### `name`

The `name` string is an optional property which should use the browser brand name and avoid English words if possible, for example `"Firefox"`, `"Firefox Android"`, `"Safari"`, `"iOS Safari"`, etc.
The `name` string is a required property which should use the browser brand name and avoid English words if possible, for example `"Firefox"`, `"Firefox Android"`, `"Safari"`, `"iOS Safari"`, etc.

### `pref_url`

An optional string containing the URL of the page where feature flags can be changed (e.g. `"about:config"` for Firefox or `"chrome://flags"` for Chrome).

### Release objects
The release objects consist of the following properties:
Expand Down
4 changes: 4 additions & 0 deletions schemas/browsers.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
"type": "string",
"description": "Browser name, avoid using unnecessary English (e.g. prefer 'Chrome Android' over 'Chrome for Android')."
},
"pref_url": {
"type": "string",
"description": "URL of the page where feature flags can be changed (e.g. 'about:config' or 'chrome://flags')."
},
"releases": {
"type": "object",
"additionalProperties": { "$ref": "#/definitions/release_statement" }
Expand Down