[All] Update FontFace data. #3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jpmedley
commented
Mar 4, 2019
jpmedley
commented
- Non-Chrome changes were generated by Confluence.
- The interface shipped in Chrome 35 by flipping the default on a runtime flag. History for runtime flags is no longer that far back. I found the beta blog post announcing its release.
- Before Chrome 45 load() and loaded returned void promises. Starting with 45 they return a FontFace instance.
Elchi3
added
the
data:api
|
I'm don't know if |
ddbeck
requested changes
Mar 13, 2019
There was a problem hiding this comment.
This PR looks pretty good, @jpmedley! Two areas of note:
- I highlighted some possible ways to to align the notes with their applicable versions. I've added suggestions for my preferred approach, but I open to alternatives.
- I would prefer to sort the workers data to the top, but it's not required.
Thank you!
|
Also, thank you for doing the sort in a separate commit. That made this much easier to review! 👌 |
|
PTAL |
ddbeck
requested changes
Mar 18, 2019
Co-Authored-By: jpmedley <jmedley@google.com>
Co-Authored-By: jpmedley <jmedley@google.com>
Co-Authored-By: jpmedley <jmedley@google.com>
Co-Authored-By: jpmedley <jmedley@google.com>
Co-Authored-By: jpmedley <jmedley@google.com>
Co-Authored-By: jpmedley <jmedley@google.com>
ddbeck
approved these changes
Mar 18, 2019
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
May 10, 2022
The source of this is mdn#3560. That linked to the IDL cleanup: https://chromium.googlesource.com/chromium/src/+/4e5bd2dafd23ae978222f7e4a73225a89a567f55 That made no actual, observable changes, as noted: > There are no changes to the generated code, other than order. Part of mdn#7844.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.