Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chromium] Add versions for WebKit-prefixed CSS properties #3887

Merged
merged 3 commits into from
Apr 15, 2019

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Apr 14, 2019

This PR is for the 2019 Key Result Q2 (#3710) by defining Chromium versions for WebKit-prefixed CSS properties with version_added: true. Looking through the Git repository of Chromium, I've found the following commits (collapsed for convenience) that implement the CSS properties.

Evidence of Use in 1.0

These commits show the properties being used in or before Chrome 1.0, or date far back enough.

css.properties.-webkit-mask-attachment

commit 805c33ce01f0e6bbeb4c900da036a15642a1f194
Author: hyatt@apple.com <hyatt@apple.com@bbb929c8-8fbe-4397-9dbb-9b2b20218538>
Date:   Mon Apr 21 21:59:33 2008 +0000

css.properties.-webkit-text-fill-color, css.properties.-webkit-text-stroke-color, css.properties.-webkit-text-stroke-width

commit b78e73454fac5bfa96ebe29a34dc00de8aac4242
Author: hyatt <hyatt@bbb929c8-8fbe-4397-9dbb-9b2b20218538>
Date:   Wed Dec 20 10:31:33 2006 +0000

Estimated by Date

These commits reveal a property's implementation, but for some reason cannot be tracked down in Chrome's release finder API. Their versions have been estimated based upon their date.

css.properties.-webkit-border-before

commit c900977d90bba47ddc2c23bbdff3c9fc4d53b224
Author: hyatt@apple.com <hyatt@apple.com@bbb929c8-8fbe-4397-9dbb-9b2b20218538>
Date:   Mon Sep 20 21:03:16 2010 +0000
Ver.?:  8

css.properties.-webkit-mask-repeat-x, css.properties.-webkit-mask-repeat-y

commit 5ea3d8d2563187f1d17ed850a9373a3dda42a606
Author: bdakin@apple.com <bdakin@apple.com@bbb929c8-8fbe-4397-9dbb-9b2b20218538>
Date:   Mon Aug 31 22:05:24 2009 +0000
Ver.?:  3

css.properties.-webkit-print-color-adjust

commit 1e6865bced6ef2adb17f93e94c0b2ea93393aa8e
Author: macpherson@chromium.org <macpherson@chromium.org@bbb929c8-8fbe-4397-9dbb-9b2b20218538>
Date:   Wed Nov 2 01:23:09 2011 +0000
Ver.?:  17

@queengooborg queengooborg added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Apr 14, 2019
@jpmedley
Copy link
Contributor

@vinyldarkscratch I just sent you a link to a version numbers and dates that I've compiled. It has information that is not in chrome.json etc.. In particular, pay attention to the column labeled 'Feature Freeze'. Generally, to be part of a particular release, a CL has to be merged before that versions feature freeze. There are edge cases, as there always are, but those required permission from Chrome management.

@queengooborg
Copy link
Contributor Author

Thanks for sharing the spreadsheet with me, this will help a lot! I’ll review it once I’ve settled into my studio office. 😉

@queengooborg queengooborg requested a review from jpmedley April 15, 2019 20:59
Copy link
Contributor

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't confirm data on the Chromium forks. Otherwise, LGTM.

@queengooborg queengooborg merged commit 55a8ac7 into mdn:master Apr 15, 2019
@queengooborg queengooborg deleted the css/webkit-prefixed-properties branch April 15, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants