Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chrome]Update MediaStream #3958

Merged
merged 3 commits into from
Apr 23, 2019
Merged

[Chrome]Update MediaStream #3958

merged 3 commits into from
Apr 23, 2019

Conversation

jpmedley
Copy link
Contributor

@jpmedley
Copy link
Contributor Author

Today I discovered that merge conflicts don't generate github emails.

@ddbeck ddbeck added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Apr 22, 2019
@ddbeck
Copy link
Collaborator

ddbeck commented Apr 22, 2019

Today I discovered that merge conflicts don't generate github emails.

Yeah, and I think the same goes for Travis CI failures. I've been thinking about this problem a bit lately (and its connection to labels). I'll open a PR or issue about addressing this later in the week

queengooborg
queengooborg requested changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@queengooborg queengooborg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Travis CI is just complaining about two things: 1) Chrome Android 19 doesn't exist (the earliest match is 25), and 2) true should not be wrapped in strings. Luckily, these are pretty easy to fix, and I've written them up as suggestions for easy click-and-merge. 😉

api/MediaStream.json Outdated Show resolved Hide resolved
api/MediaStream.json Outdated Show resolved Hide resolved
queengooborg and others added 2 commits April 22, 2019 19:12
@queengooborg @jpmedley
Update api/MediaStream.json
4f884dd 
Co-Authored-By: jpmedley <jmedley@google.com>
@queengooborg @jpmedley
Update api/MediaStream.json
2ae32dd 
Co-Authored-By: jpmedley <jmedley@google.com>
@queengooborg queengooborg merged commit 5dde9e1 into mdn:master Apr 23, 2019
@jpmedley jpmedley deleted the media-stream branch April 23, 2019 17:08
@foolip foolip mentioned this pull request May 11, 2022
Merged
foolip added a commit to foolip/browser-compat-data that referenced this pull request May 11, 2022
@foolip
Update Chromium versions for MediaStream/MediaStreamTrack's clone()
e85c5bd 
Original source: mdn#3958

However, https://chromium.googlesource.com/chromium/src/+/776e9a66223e95141b0b8bc6c6f9a847cd5fd8c4
was long before Chrome 45. Support was tested using
`webkitMediaStream.prototype.clone` and `MediaStreamTrack.prototype.clone`
in Chrome 34 and 45. (One interface was prefixed at the time.)

Part of mdn#7844.
foolip added a commit to foolip/browser-compat-data that referenced this pull request May 11, 2022
@foolip
Update Chromium versions for MediaStream/MediaStreamTrack's clone()
b1cb2c7 
Original source: mdn#3958

However, https://chromium.googlesource.com/chromium/src/+/776e9a66223e95141b0b8bc6c6f9a847cd5fd8c4
was long before Chrome 45. Support was tested using
`webkitMediaStream.prototype.clone` and `MediaStreamTrack.prototype.clone`
in Chrome 34 and 35. (One interface was prefixed at the time.)

Part of mdn#7844.
foolip added a commit to foolip/browser-compat-data that referenced this pull request May 11, 2022
@foolip
Update Chromium versions for MediaStream/MediaStreamTrack's clone()
20ec69b 
Original source: mdn#3958

However, https://chromium.googlesource.com/chromium/src/+/776e9a66223e95141b0b8bc6c6f9a847cd5fd8c4
was long before Chrome 45. Support was tested using
`webkitMediaStream.prototype.clone` and `MediaStreamTrack.prototype.clone`
in Chrome 34 and 35. (One interface was prefixed at the time.)

Part of mdn#7844.
foolip added a commit to foolip/browser-compat-data that referenced this pull request May 11, 2022
@foolip
Update Chromium versions for MediaStream.getTracks
4abf8fc 
Original source: mdn#3958

However, https://chromium.googlesource.com/chromium/src/+/e99d73de1761aec44e23381e565ee48430d9a699
was long before Chrome 45. Support was tested using
`webkitMediaStream.prototype.getTracks` in Chrome 37 and 38.

Part of mdn#7844.
@foolip foolip mentioned this pull request May 11, 2022
Merged
queengooborg pushed a commit that referenced this pull request May 11, 2022
@foolip
Update Chromium versions for MediaStream.getTracks (#16246)
4270fe5 
Original source: #3958

However, https://chromium.googlesource.com/chromium/src/+/e99d73de1761aec44e23381e565ee48430d9a699
was long before Chrome 45. Support was tested using
`webkitMediaStream.prototype.getTracks` in Chrome 37 and 38.

Part of #7844.
queengooborg pushed a commit that referenced this pull request May 11, 2022
@foolip
Update Chromium versions for MediaStream/MediaStreamTrack's clone() (#…
f913790 
…16245)

Original source: #3958

However, https://chromium.googlesource.com/chromium/src/+/776e9a66223e95141b0b8bc6c6f9a847cd5fd8c4
was long before Chrome 45. Support was tested using
`webkitMediaStream.prototype.clone` and `MediaStreamTrack.prototype.clone`
in Chrome 34 and 35. (One interface was prefixed at the time.)

Part of #7844.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpmedley @ddbeck @queengooborg