Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added -webkit-line-clamp CSS property #4142

Merged
merged 6 commits into from
May 16, 2019

Conversation

SebastianZ
Copy link
Contributor

This patch adds the -webkit-line-clamp CSS property.

For the data I've checked https://caniuse.com/#feat=css-line-clamp and tested in the current versions of Chrome, IE, Edge, and Opera. In Firefox this got implemented in version 68, see bug 866102.

Sebastian

@SebastianZ SebastianZ force-pushed the webkit-line-clamp branch from c0435d6 to 355eaa6 Compare May 12, 2019 19:09
@SebastianZ SebastianZ force-pushed the webkit-line-clamp branch from 355eaa6 to 9c91ace Compare May 12, 2019 19:19
@queengooborg queengooborg added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label May 12, 2019
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of updates to the version numbers of certain browsers, and this looks good to go!

css/properties/-webkit-line-clamp.json Outdated Show resolved Hide resolved
css/properties/-webkit-line-clamp.json Outdated Show resolved Hide resolved
css/properties/-webkit-line-clamp.json Outdated Show resolved Hide resolved
css/properties/-webkit-line-clamp.json Outdated Show resolved Hide resolved
css/properties/-webkit-line-clamp.json Outdated Show resolved Hide resolved
SebastianZ and others added 5 commits May 16, 2019 22:40
Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com>
Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com>
Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com>
Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com>
Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com>
@SebastianZ
Copy link
Contributor Author

SebastianZ commented May 16, 2019

Thank you for the feedback, @vinyldarkscratch! I've verified your suggestions with the versions listed on Wikipedia and you're right. So, I've incorporated all your changes.

@queengooborg
Copy link
Contributor

Thanks for the changes, looking perfect now!

@queengooborg queengooborg merged commit 4664870 into mdn:master May 16, 2019
@connorshea
Copy link
Contributor

connorshea commented May 22, 2019

@vinyldarkscratch @SebastianZ the property in this file is called -webkit-box-reflect :) I'll open a PR to fix it.

connorshea added a commit to connorshea/browser-compat-data that referenced this pull request May 22, 2019
queengooborg pushed a commit that referenced this pull request May 22, 2019
@SebastianZ
Copy link
Contributor Author

@vinyldarkscratch @SebastianZ the property in this file is called -webkit-box-reflect :) I'll open a PR to fix it.

Sorry for the mistake and the late reply! And thank you, @connorshea, for fixing it!

Sebastian

@rabbit-roger
Copy link

CSS property -webkit-line-clamp doesn't work in iOS in Safari and Chrome browsers, nor in the desktop version of Safari when direction:rtl is added. That is, for right-to-left languages, the property only works in the desktop version of Chrome and Chrome for Android for both text directions.
A footnote should be made about partial support in these browsers.

@ddbeck
Copy link
Collaborator

ddbeck commented Feb 17, 2021

@Mihkach You've commented on a rather old PR and this comment is not likely to be followed up on here. So that this information is not lost, please open a new issue using the data problem template. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants