-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added -webkit-line-clamp CSS property #4142
Conversation
c0435d6
to
355eaa6
Compare
355eaa6
to
9c91ace
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of updates to the version numbers of certain browsers, and this looks good to go!
Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com>
Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com>
Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com>
Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com>
Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com>
Thank you for the feedback, @vinyldarkscratch! I've verified your suggestions with the versions listed on Wikipedia and you're right. So, I've incorporated all your changes. |
Thanks for the changes, looking perfect now! |
@vinyldarkscratch @SebastianZ the property in this file is called |
Introduced in mdn#4142.
Sorry for the mistake and the late reply! And thank you, @connorshea, for fixing it! Sebastian |
CSS property |
@Mihkach You've commented on a rather old PR and this comment is not likely to be followed up on here. So that this information is not lost, please open a new issue using the data problem template. Thank you. |
This patch adds the
-webkit-line-clamp
CSS property.For the data I've checked https://caniuse.com/#feat=css-line-clamp and tested in the current versions of Chrome, IE, Edge, and Opera. In Firefox this got implemented in version 68, see bug 866102.
Sebastian