Add columns CSS properties compat data #435
Conversation
teoli2003
added
the
data:css
| }, | ||
| { | ||
| "prefix": "-moz-", | ||
| "version_added": "1.5" |
There was a problem hiding this comment.
This should be "1", there wasn't a 1.5 for Android, and 1.0 was done more or less when 3.0 went out on Desktop. See column-width entry.
css/properties/column-count.json
Outdated
| "version_added": true | ||
| }, | ||
| "opera": { | ||
| "version_added": "11.10" |
There was a problem hiding this comment.
The -webkit- prefixed version exists in Opera since 15
css/properties/column-count.json
Outdated
| "version_added": "11.10" | ||
| }, | ||
| "opera_android": { | ||
| "version_added": true |
There was a problem hiding this comment.
Add -webkit- prefix with true too.
css/properties/column-count.json
Outdated
| "version_added": "3" | ||
| }, | ||
| "safari_ios": { | ||
| "version_added": true |
There was a problem hiding this comment.
With -webkit- prefix too.
css/properties/column-gap.json
Outdated
| "version_added": "10" | ||
| }, | ||
| "opera": { | ||
| "version_added": "11.10" |
There was a problem hiding this comment.
Add -webkit- prefix with "15" too.
css/properties/column-width.json
Outdated
| "safari_ios": { | ||
| "version_added": true | ||
| } | ||
| } |
There was a problem hiding this comment.
Status is missing too. Is this a standard behaviour?
There was a problem hiding this comment.
Like above, I'm not sure. I looked over the standards documents link from both the column-width and display property pages and couldn't find any mention of interaction between the two. Again, I don't know what behavior this refers to.
There was a problem hiding this comment.
OK, added status statement.
css/properties/column-count.json
Outdated
| "safari_ios": { | ||
| "version_added": true | ||
| } | ||
| } |
There was a problem hiding this comment.
Status is missing. Is this a standard behaviour?
There was a problem hiding this comment.
I'm not sure. I looked over the standards documents link from both the column-count and display property pages and couldn't find any mention of interaction between the two. I'm honestly not sure what behavior it refers to, to be honest.
There was a problem hiding this comment.
OK, statement added.
css/properties/columns.json
Outdated
| "safari_ios": { | ||
| "version_added": true | ||
| } | ||
| } |
There was a problem hiding this comment.
Status is missing. Is this a standard behaviour?
There was a problem hiding this comment.
Another "on display: table-caption" case. Again, I don't know how to handle the status statement on this subfeature either.
There was a problem hiding this comment.
It is standard, and non-experimental.
css/properties/column-gap.json
Outdated
| "firefox_android": [ | ||
| { | ||
| "version_added": "52", | ||
| "notes": "Before Firefox 3, the default value for the <code>normal</code> keyword was <code>0</code> and not <code>1em</code>." |
There was a problem hiding this comment.
You can remove this note. Fx Android 1 came after the fix.
css/properties/column-gap.json
Outdated
| "firefox": [ | ||
| { | ||
| "version_added": "52", | ||
| "notes": "Before Firefox 3, the default value for the <code>normal</code> keyword was <code>0</code> and not <code>1em</code>." |
There was a problem hiding this comment.
Move to the prefixed version entry.
|
@teoli2003 I think the I've fixed the other issues, so if you've got guidance on status statements, I'd appreciate it. Thanks! |
css/properties/column-count.json
Outdated
| "safari_ios": { | ||
| "version_added": true | ||
| } | ||
| } |
css/properties/column-width.json
Outdated
| "safari_ios": { | ||
| "version_added": false | ||
| } | ||
| } |
There was a problem hiding this comment.
Given that there are 0 implementation, it can't be anything else than experimental.
css/properties/column-width.json
Outdated
| "safari_ios": { | ||
| "version_added": true | ||
| } | ||
| } |
css/properties/columns.json
Outdated
| "safari_ios": { | ||
| "version_added": true | ||
| } | ||
| } |
There was a problem hiding this comment.
It is standard, and non-experimental.
css/properties/column-count.json
Outdated
| "safari_ios": { | ||
| "version_added": true | ||
| } | ||
| } |
There was a problem hiding this comment.
OK, statement added.
css/properties/column-width.json
Outdated
| "safari_ios": { | ||
| "version_added": false | ||
| } | ||
| } |
There was a problem hiding this comment.
OK, status statement added.
css/properties/column-width.json
Outdated
| "safari_ios": { | ||
| "version_added": true | ||
| } | ||
| } |
There was a problem hiding this comment.
OK, added status statement.
css/properties/columns.json
Outdated
| "safari_ios": { | ||
| "version_added": true | ||
| } | ||
| } |
This PR adds compat data for the following CSS properties:
The source tables are a bit iffy, with lots of suspect columns for Android, Android Webview, and Chrome for Android. The
columnsproperty is probably a good example of how I've tried to interpret the tables (e.g., rather than reconcile Webview and Android version numbers, I went withtruein some cases). Happy to make corrections, if desired.