-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set real values for various Chromium + Safari CSS @rules #4368
Set real values for various Chromium + Safari CSS @rules #4368
Conversation
Hi @vinyldarkscratch. Would you update your description to link to the bugs and changes mentioned here? It'll be a lot easier to review this without copying and pasting everything |
Oh sorry! I forgot GitHub doesn’t automatically generate links inside of HTML tags. Certainly, I’ll update this one, as well as my other similar PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few issues of note here. Great start on this, @vinyldarkscratch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you! 🎉
This PR is to assist in the efforts of #3710, or more specifically, #4294. I've browsed through WebKit and Blink to identify the exact versions where features were added/removed (if supported at all). Based on the following data, this sets versions within Chrome, Chrome Android, Safari, Safari iOS, Opera, Opera Android, Samsung Internet, and WebView:
css.at-rules.font-face.SVG_fonts
css.at-rules.font-face.font-display
css.at-rules.font-face.unicode-range
css.at-rules.import
css.at-rules.keyframes (-webkit- prefix)
css.at-rules.keyframes.ignore_important_declarations
css.at-rules.media.-moz-device-pixel-ratio
css.at-rules.page.size
Note: all commit hashes are for the WebKit Git mirror.
I have requested @jpmedley’s review on all the Chrome versions, but any and all reviews are welcome!