-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set real values for Chromium + Safari CSS @media properties #4369
Set real values for Chromium + Safari CSS @media properties #4369
Conversation
I'm confident in my Safari versions, and Chrome's already been approved. I'll go ahead and merge this one. |
@vinyldarkscratch The resolution part vs WebKit seems strange because:
(If anyone gets |
Hmm...thanks for the heads up, @fvsch! Looking at the two bugs (the one you've linked and the one I've linked), it appears that they both block each other, and based upon the titles, I would assume they are the same thing, but then why wouldn't one be marked as a duplicate of the other? From the example on MDN, I tested in Chrome and Safari, and can confirm your suspicions that Safari does not support this feature. So then when did Chrome implement support...? This is something to look into once again. I would be grateful if you could follow up to this one as I'm working on the rest of the Lena Horne milestone, but I totally understand if you're unable to! |
For the Chrome release with |
The ChromeStatus post also specifically has the wording "Enabled by default (tracking bug) in: Chrome 29", which I think confirms your theory in itself. That would also explain why there's a commit for it in WebKit, hidden behind a flag -- it must have been added in Safari 6.1 / Chrome 27, but never enabled in Safari. (This also tells me I need to be more careful about flags!) |
This PR adds real values for Safari (Desktop and iOS/iPadOS) for the `media` CSS @rule. Since there is nothing in the [source code for Safari 2](https://trac.webkit.org/browser/webkit/tags/old/Safari-421/WebCore/khtml/css) for media queries, it doesn't make sense for this to be set to Safari 1.3. As I have found in mdn#4369, support for pretty much every part of media queries hadn't been introduced until at least Safari 3.
This PR adds real values for Safari (Desktop and iOS/iPadOS) for the `media` CSS @rule. Since there is nothing in the [source code for Safari 2](https://trac.webkit.org/browser/webkit/tags/old/Safari-421/WebCore/khtml/css) for media queries, it doesn't make sense for this to be set to Safari 1.3. As I have found in #4369, support for pretty much every part of media queries hadn't been introduced until at least Safari 3.
Original source: mdn#4369 The source given, which is unfortunately wrong: https://storage.googleapis.com/chromium-find-releases-static/02b.html#02b80e73d179e8b87d007b197766fa5fca1a80ee Chrome 42 was confirmed by testing and commit date: https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=10306 https://chromium.googlesource.com/chromium/src/+/02b80e73d179e8b87d007b197766fa5fca1a80ee https://www.chromium.org/developers/calendar/ Part of mdn#7844.
Original source: #4369 The source given, which is unfortunately wrong: https://storage.googleapis.com/chromium-find-releases-static/02b.html#02b80e73d179e8b87d007b197766fa5fca1a80ee Chrome 42 was confirmed by testing and commit date: https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=10306 https://chromium.googlesource.com/chromium/src/+/02b80e73d179e8b87d007b197766fa5fca1a80ee https://www.chromium.org/developers/calendar/ Part of #7844.
This PR is to assist in the efforts of #3710, or more specifically, #4294. I've browsed through WebKit and Blink to identify the exact versions where features were added/removed (if supported at all). Based on the following data, this sets versions within Chrome, Chrome Android, Safari, Safari iOS, Opera, Opera Android, Samsung Internet, and WebView:
css.at-rules.media.color, css.at-rules.media.device-aspect-ratio, css.at-rules.media.device-height, css.at-rules.media.device-width, css.at-rules.media.grid, css.at-rules.media.height, css.at-rules.media.width
css.at-rules.media.aspect-ratio, css.at-rules.media.orientation
css.at-rules.media.color-gamut
css.at-rules.media.color-index
css.at-rules.media.display-mode
css.at-rules.media.inverted-colors
css.at-rules.media.monochrome
css.at-rules.media.resolution
css.at-rules.media.-webkit-animation, css.at-rules.media.-webkit-transition, css.at-rules.media.-webkit-transform-2d, css.at-rules.media.-webkit-transform-3d
css.at-rules.media.-webkit-device-pixel-ratio, css.at-rules.media.-webkit-max-device-pixel-ratio, css.at-rules.media.-webkit-min-device-pixel-ratio
Note: all commit hashes are for the WebKit Git mirror.
I have requested @jpmedley’s review on all the Chrome versions, but any and all reviews are welcome!