Update Chromium support for api.RTCIceCandidate (and add address) #4398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queengooborg
added
the
data:api
|
That deep link doesn't work for me. Can you give this more context/proofs? |
|
Sure thing! @jpmedley had reviewed #3826 and mentioned that members RTCIceCandidate were changed to |
|
Ah okay thanks! In this case, it sounds like @jpmedley is most qualified to review this PR :) |
jpmedley
suggested changes
Jul 9, 2019
There was a problem hiding this comment.
All the data you have looks good. Here's what's missing.
port (74)
protocol (74)
sdpMid (23)
sdpMLineIndex (23)
toJSON (45)
candidate is also 23.
|
I already added |
jpmedley
approved these changes
Jul 9, 2019
|
Thanks @jpmedley! |
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Oct 21, 2021
The source of this data is this comment: mdn#4398 (review) However, because of a problem with Chromium's "Find Releases" tool, Chrome 45 is often claimed for commits older than that: mdn#7844 Chrome 43 was confirmed by testing 42 and 43 with this test: http://mdn-bcd-collector.appspot.com/tests/api/RTCIceCandidate/toJSON Chrome 43 is also what commit date + branch point dates suggests: https://source.chromium.org/chromium/chromium/src/+/4a6ce1a6ad82c9b9f16bcb136303acadf08422ea https://www.chromium.org/developers/calendar
queengooborg
pushed a commit
that referenced
this pull request
Oct 23, 2021
The source of this data is this comment: #4398 (review) However, because of a problem with Chromium's "Find Releases" tool, Chrome 45 is often claimed for commits older than that: #7844 Chrome 43 was confirmed by testing 42 and 43 with this test: http://mdn-bcd-collector.appspot.com/tests/api/RTCIceCandidate/toJSON Chrome 43 is also what commit date + branch point dates suggests: https://source.chromium.org/chromium/chromium/src/+/4a6ce1a6ad82c9b9f16bcb136303acadf08422ea https://www.chromium.org/developers/calendar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from https://github.com/mdn/browser-compat-data/pull/3826/files/8256f08e7da5e8bc40ffde494aaa3aba6686bc29#r298342645.