Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Chromium/Safari real values for -webkit- selectors #4402

Merged

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Jun 30, 2019

This PR is to assist in the efforts of #3710, or more specifically, #4302. I've browsed through WebKit and Blink to identify the exact versions where features were added/removed (if supported at all). Based on the following data, this sets versions within Chrome, Chrome Android, Safari, Safari iOS, Opera, Opera Android, Samsung Internet, and WebView:

css.selectors.-webkit-meter-bar, css.selectors.-webkit-meter-even-less-good-value, css.selectors.-webkit-meter-optimum-value, css.selectors.-webkit-meter-suboptimum-value
  • Selector introduced in b62b168a43e72d94cda45951a46ee41bbba164a6
  • Introduced in WebKit 534.27
  • Safari 5.1, Chrome 12
css.selectors.-webkit-meter-inner-element
  • Selector introduced in 90ea5ef61645406cb4097db462b2587d27e94caa
  • Introduced in WebKit 537.6
  • Safari 6.1, Chrome 23
css.selectors.-webkit-progress-bar, css.selectors.-webkit-progress-value
  • Selector introduced in e7d31a94b857860c5b0455361e0ab9880676324f
  • Introduced in WebKit 537.20
  • Safari 6.1, Chrome 25
css.selectors.-webkit-progress-inner-element
  • Selector introduced in c44aafaf909a6a3d7173df246860daa725196870
  • Introduced in WebKit 537.5
  • Safari 6.1, Chrome 23
css.selectors.-webkit-resizer
  • Selector introduced in ca798134c0d934914dfb577b62b96ba09043b546
  • Introduced in WebKit 528.5
  • Safari 4, Safari 2
css.selectors.-webkit-scrollbar-button, css.selectors.-webkit-scrollbar-corner, css.selectors.-webkit-scrollbar-thumb, css.selectors.-webkit-scrollbar-track, css.selectors.-webkit-scrollbar
  • Selector introduced in 5c9a9f7d7dcc992ca776f46b2f57aec0fe97e0a4
  • Introduced in WebKit 528.5
  • Safari 4, Safari 2
css.selectors.-webkit-scrollbar-track-piece
  • Selector introduced in 2e4835da13019b0539dd6274d359d4d92919c14c
  • Introduced in WebKit 528.5
  • Safari 4, Safari 2
css.selectors.-webkit-search-cancel-button, css.selectors.-webkit-search-results-button
  • Selector introduced in 4b760b99891b20a3ff2cc5e69ccff8dde1adb928
  • Introduced in WebKit 521.33
  • Safari 3, Chrome 1

Note: all commit hashes are for the WebKit Git mirror.

I have requested @ddbeck's review as they have taken a strong initiative on this project, but any and all reviews are welcome!

@queengooborg queengooborg added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Jun 30, 2019
@queengooborg queengooborg requested a review from ddbeck June 30, 2019 06:55
@ddbeck
Copy link
Collaborator

ddbeck commented Jul 3, 2019

Thanks for this PR, @vinyldarkscratch.

I'm working through this and I afraid I don't follow how the commits mentioned for css.selectors.-webkit-progress-inner-element relate to the feature. Can you spell that out a bit more?

The rest of the sources look fine, though I admit I've only partially reviewed this so far (I haven't checked the diff itself to make sure your files match the intent).

@ddbeck ddbeck removed their request for review July 3, 2019 13:19
@queengooborg
Copy link
Contributor Author

Just looked deeper into the git log. Fixed the version numbers based upon further research!

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you! 🎉

@ddbeck ddbeck merged commit 78dff1c into mdn:master Jul 4, 2019
@queengooborg queengooborg deleted the real-values/safari-chrome/webkit-selectors branch July 4, 2019 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants