Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadReplace; refactor tabs.update data #446

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Conversation

wbamberg
Copy link
Contributor

@wbamberg wbamberg commented Oct 3, 2017

https://bugzilla.mozilla.org/show_bug.cgi?id=1397383 adds a loadReplace option to the updateProperties argument given to tabs.update:

https://hg.mozilla.org/mozilla-central/diff/442345c31f98/browser/components/extensions/schemas/tabs.json

This PR adds that, and also splits out all the other bits of updateProperties. Some were already split out, but I've now put them explicitly under updateProperties.

I'm liking the new more flexible schema :).

@teoli2003 teoli2003 added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Oct 3, 2017
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

@teoli2003 teoli2003 merged commit cacd113 into master Oct 4, 2017
@Elchi3 Elchi3 deleted the tabs-replace branch October 4, 2017 09:03
queengooborg added a commit to queengooborg/browser-compat-data that referenced this pull request Jul 20, 2024
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `tabs` Web Extensions interface. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD.

Commit/PR Adding the Feature: mdn#512, mdn#469, mdn#446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants