Add at-rule @keyframes compat data #476

ddbeck · 2017-10-05T20:55:03Z

This PR adds one at-rule, @keyframes. Since it's the first of it's kind, I figured I should open a PR for this one alone.

teoli2003

Really good, we just need to get CSS Animations prefixes straight. (And we need to tell this grim and scary story ;-) )

teoli2003 · 2017-10-06T06:08:48Z

css/at-rules/keyframes.json

+              },
+              {
+                "prefix": "-o-",
+                "version_added": "12"


"version_removed": "15"

teoli2003 · 2017-10-06T06:09:39Z

css/at-rules/keyframes.json

+            },
+            "opera": [
+              {
+                "version_added": "12.10"


"version_removed": "15"

(Opera lost support for unprefixed CSS Animations when moving to Chromium/Blink

teoli2003 · 2017-10-06T06:10:17Z

css/at-rules/keyframes.json

+                "version_added": "12"
+              }
+            ],
+            "opera_android": {


Same as Opera.

teoli2003 · 2017-10-06T06:10:47Z

css/at-rules/keyframes.json

+              }
+            ],
+            "safari_ios": {
+              "version_added": null


Set 'true'. Also add a prefix "-webkit-" version, also set to 'true'

teoli2003 · 2017-10-06T06:11:13Z

css/at-rules/keyframes.json

+              "version_added": "10"
+            },
+            "ie_mobile": {
+              "version_added": null


Set to 'true'

teoli2003 · 2017-10-06T06:12:55Z

css/at-rules/keyframes.json

+            "opera": [
+              {
+                "version_added": "12.10"
+              },


Add an extra entry for the -webkit- prefixing story:
{
"version_added": "15",
"prefix": "-webkit-"
},

teoli2003 · 2017-10-06T06:25:58Z

css/at-rules/keyframes.json

+              {
+                "version_added": "16"
+              },
+              {


We need to add two {} blocks to describe the story of -webkit- prefixes in Firefox (added in 44 behind a pref, without a pref in 49)

{ "version_added": "49", "prefix": "-webkit-" }, { "version_added": "44", "prefix": "-webkit-", "flag": { "type": "preference", "name": "layout.css.prefixes.webkit", "value_to_set": "true" } },

teoli2003 · 2017-10-06T06:26:16Z

css/at-rules/keyframes.json

+                "version_added": "5"
+              }
+            ],
+            "firefox_android": [


Same as Firefox (-webkit- prefixes)

teoli2003 · 2017-10-06T06:30:41Z

css/at-rules/keyframes.json

+        "__compat": {
+          "mdn_url": "https://developer.mozilla.org/docs/Web/CSS/@keyframes",
+          "support": {
+            "webview_android": {


Added unprefixed version in "43" too.

teoli2003 · 2017-10-06T06:31:03Z

css/at-rules/keyframes.json

+                "version_added": true
+              }
+            ],
+            "chrome_android": {


Also supported (same as "chrome")

teoli2003 · 2017-10-06T06:33:24Z

css/at-rules/keyframes.json

+              "safari_ios": {
+                "version_added": null
+              }
+            }


Add a "status" box. (This is standard behaviour; the spec says 'Animations override all normal rules, but are overriden by !important rules. ')

teoli2003

This one is really close to land :-)

teoli2003 · 2017-10-06T07:33:29Z

@Elchi3 Quick question: is it ok to have a dash in the identifier (and in the directory name):

"css": {
    "at-rules": {
      "@keyframes": {

?

Elchi3 · 2017-10-06T07:59:11Z

Yes, that should be alright. The mdn/data repo also uses "at-rules" and accessing the data using "css.at-rules.@keyframes" should work just fine.

ddbeck · 2017-10-07T10:10:49Z

OK, I think this one is ready for another look, @teoli2003.

This did remind me of a question, too: I've seen tables with Android Webview version numbers that seem to be Android version numbers (e.g., 4.3, 4.4, 5, etc.) and some that correspond to Chrome version numbers (e.g., 36, 43, etc.)? What's the right way to migrate Webview? Keep the number regardless of the sequence they belong to? Go to true when it's an Android version number?

ddbeck · 2017-10-07T10:13:23Z

Also, I agree this is a grim and scary story, but at least it's the right time of year for it. 🎃

teoli2003 · 2017-10-08T05:28:20Z

Before Android 4.4, the Webview wasn't based on Chromium and has only the Android version. From Android 4.4, it is based on Chromium (like 4.4 is based on Chromium 30). So Webview should not be the Android version for 4.4 or larger.

@Elchi3 is adding version validation and I think the Webview versions will added to these checks at some point. Meanwhile, I would say to not lose information (I prefer a 5 that we will convert to a Chrome-based version later to a true that will stay like this forever).

teoli2003

LGTM, r+

Add at-rule: @Keyframes

538c1db

teoli2003 added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Oct 5, 2017

teoli2003 reviewed Oct 6, 2017

View reviewed changes

css/at-rules/keyframes.json Outdated

"version_added": true

}

],

"chrome_android": {

Copy link

Contributor

teoli2003 Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also supported (same as "chrome")

teoli2003 reviewed Oct 6, 2017

View reviewed changes

teoli2003 suggested changes Oct 6, 2017

View reviewed changes

ddbeck added 6 commits October 7, 2017 10:58

Add status information for @Keyframes !important behavior

1381bb2

Add compat data to @Keyframes for iOS Safari

1fbe42a

Add compat data to @Keyframes for Opera and Opera for Android

18ed118

Add compat data to @Keyframes for IE Mobile

878e039

Add webkit prefix compat data to @Keyframes for Firefox (incl. Android)

6ace145

Add compat data to @Keyframes Chrome for Android and Webview

da433fd

teoli2003 approved these changes Oct 8, 2017

View reviewed changes

teoli2003 merged commit ce6fec7 into mdn:master Oct 8, 2017

ddbeck deleted the css-keyframes branch October 8, 2017 09:37

Woodpile37 mentioned this pull request Aug 22, 2023

[Snyk] Upgrade c8 from 7.13.0 to 8.0.1 Woodpile37/browser-compat-data#23

Merged

Aknc34 mentioned this pull request Jan 3, 2024

[Snyk] Security upgrade c8 from 7.12.0 to 9.0.0 Aknc34/browser-compat-data#6

Open

adamlaska mentioned this pull request Jan 4, 2024

[Snyk] Security upgrade c8 from 7.12.0 to 9.0.0 adamlaska/browser-compat-data#15

Open

BitcoinOutput mentioned this pull request Jan 4, 2024

[Snyk] Security upgrade c8 from 7.13.0 to 9.0.0 BitcoinOutput/browser-compat-data#8

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add at-rule @keyframes compat data #476

Add at-rule @keyframes compat data #476

ddbeck commented Oct 5, 2017

teoli2003 left a comment

teoli2003 Oct 6, 2017

teoli2003 Oct 6, 2017

teoli2003 Oct 6, 2017

teoli2003 Oct 6, 2017

teoli2003 Oct 6, 2017

teoli2003 Oct 6, 2017

teoli2003 Oct 6, 2017 •

edited

Loading

teoli2003 Oct 6, 2017

teoli2003 Oct 6, 2017

teoli2003 Oct 6, 2017

teoli2003 Oct 6, 2017

teoli2003 left a comment

teoli2003 commented Oct 6, 2017

Elchi3 commented Oct 6, 2017 •

edited

Loading

ddbeck commented Oct 7, 2017

ddbeck commented Oct 7, 2017

teoli2003 commented Oct 8, 2017

teoli2003 left a comment

Add at-rule @keyframes compat data #476

Add at-rule @keyframes compat data #476

Conversation

ddbeck commented Oct 5, 2017

teoli2003 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teoli2003 Oct 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teoli2003 left a comment

Choose a reason for hiding this comment

teoli2003 commented Oct 6, 2017

Elchi3 commented Oct 6, 2017 • edited Loading

ddbeck commented Oct 7, 2017

ddbeck commented Oct 7, 2017

teoli2003 commented Oct 8, 2017

teoli2003 left a comment

Choose a reason for hiding this comment

teoli2003 Oct 6, 2017 •

edited

Loading

Elchi3 commented Oct 6, 2017 •

edited

Loading