Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy generator data #6017

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Remove legacy generator data #6017

merged 1 commit into from
Apr 22, 2020

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Apr 21, 2020

It's now more than two years after removal. I've moved the content into the archive and removed the compat tables from the pages.

There is no reason to keep this around any more and I think it should disappear from other data consumers. (https://caniuse.com/#search=legacy)

@ghost ghost added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Apr 21, 2020
@ddbeck
Copy link
Collaborator

ddbeck commented Apr 21, 2020

I'm OK with old, removed features being removed from BCD, but I think we ought to come up with and document a guideline for removing obsoleted (is that word? I hope so) features. There are other features like this and it would be nice to have a consistent, reviewable set of criteria for their removal too.

@Elchi3
Copy link
Member Author

Elchi3 commented Apr 21, 2020

You're absolutely right about that! I've opened a PR to add such a guideline: #6018

(the removal here meets both of the two criteria, fwiw)

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we've formally adopted the policy in #6018, I'm approving this. Thank you, Florian! 🎉

@ddbeck ddbeck merged commit 688fc87 into master Apr 22, 2020
@ddbeck ddbeck deleted the remove-legacy-generators branch April 22, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants