Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results from mdn-bcd-collector for DOM* APIs #6568

Merged
merged 15 commits into from
Sep 1, 2020

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Aug 26, 2020

This PR provides results collected from mdn-bcd-collector for the DOM* APIs. All versions have been verified manually in SauceLabs and through searching Chromium Code Search to verify the commits. (All invalid data was removed from this PR and either corrected on the collector or separated into a new PR.)

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 26, 2020
@queengooborg queengooborg requested a review from foolip August 27, 2020 19:51
api/DOMException.json Show resolved Hide resolved
api/DOMException.json Show resolved Hide resolved
api/DOMException.json Show resolved Hide resolved
api/DOMException.json Outdated Show resolved Hide resolved
api/DOMException.json Outdated Show resolved Hide resolved
api/DOMTokenList.json Show resolved Hide resolved
api/DOMTokenList.json Outdated Show resolved Hide resolved
api/DOMException.json Outdated Show resolved Hide resolved
api/DOMPointReadOnly.json Outdated Show resolved Hide resolved
api/DOMQuad.json Outdated Show resolved Hide resolved
api/DOMException.json Outdated Show resolved Hide resolved
api/DOMStringList.json Show resolved Hide resolved
api/DOMRect.json Show resolved Hide resolved
api/DOMRect.json Outdated Show resolved Hide resolved
api/DOMMatrixReadOnly.json Show resolved Hide resolved
api/DOMPointReadOnly.json Show resolved Hide resolved
api/DOMQuad.json Show resolved Hide resolved
api/DOMTokenList.json Show resolved Hide resolved
@foolip
Copy link
Contributor

foolip commented Aug 31, 2020

@vinyldarkscratch I've reviewed this again now. The only remaining issues are mirroring. If you do that I can merge tomorrow.

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I've gone over everything again. I'm confident this is a huge improvement in the data, but acknowledge it's possible some detail of this ends up being wrong. We will eventually find out with more automation :)

api/DOMMatrixReadOnly.json Show resolved Hide resolved
@foolip foolip merged commit cecc257 into mdn:master Sep 1, 2020
@queengooborg queengooborg deleted the collector/api/DOM branch September 1, 2020 08:22
@ddbeck
Copy link
Collaborator

ddbeck commented Sep 2, 2020

I just wanted to thank you both for carrying this along. I looked at some of this briefly and it seems like a big effort. Way to go!

foolip added a commit to foolip/browser-compat-data that referenced this pull request Jul 13, 2022
These are all cases where the source data was updated but the mirrored
data wasn't updated. Assume that the changes in the PRs are correct and
use "mirror" to get the data in sync again.

AudioContext: mdn#1579

CSSTransition: mdn#6707

DOMTokenList: mdn#6568

MutationRecord: mdn#12457

RTCDataChannelEvent: mdn#12895

Response: mdn#12579
queengooborg pushed a commit that referenced this pull request Jul 13, 2022
These are all cases where the source data was updated but the mirrored
data wasn't updated. Assume that the changes in the PRs are correct and
use "mirror" to get the data in sync again.

AudioContext: #1579

CSSTransition: #6707

DOMTokenList: #6568

MutationRecord: #12457

RTCDataChannelEvent: #12895

Response: #12579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants