-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Results from mdn-bcd-collector for DOM* APIs #6568
Conversation
@vinyldarkscratch I've reviewed this again now. The only remaining issues are mirroring. If you do that I can merge tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I've gone over everything again. I'm confident this is a huge improvement in the data, but acknowledge it's possible some detail of this ends up being wrong. We will eventually find out with more automation :)
I just wanted to thank you both for carrying this along. I looked at some of this briefly and it seems like a big effort. Way to go! |
These are all cases where the source data was updated but the mirrored data wasn't updated. Assume that the changes in the PRs are correct and use "mirror" to get the data in sync again. AudioContext: mdn#1579 CSSTransition: mdn#6707 DOMTokenList: mdn#6568 MutationRecord: mdn#12457 RTCDataChannelEvent: mdn#12895 Response: mdn#12579
These are all cases where the source data was updated but the mirrored data wasn't updated. Assume that the changes in the PRs are correct and use "mirror" to get the data in sync again. AudioContext: #1579 CSSTransition: #6707 DOMTokenList: #6568 MutationRecord: #12457 RTCDataChannelEvent: #12895 Response: #12579
This PR provides results collected from mdn-bcd-collector for the
DOM*
APIs. All versions have been verified manually in SauceLabs and through searching Chromium Code Search to verify the commits. (All invalid data was removed from this PR and either corrected on the collector or separated into a new PR.)