-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Chrome data for Document features that were on HTMLDocument alias #6865
Conversation
@ddbeck I'd like your review on the note wording for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notes look good to me now, the only issue I can spot now is the Opera Presto ranges, which can probably all be collapsed.
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Ping @vinyldarkscratch. If there's something tricky to resolve here, maybe we can split out those changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done another lighter review, all looks good to me now!
"notes": "Starting in Chrome 65, this property is readonly." | ||
}, | ||
{ | ||
"version_added": "3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
document.all
added in Chrome 3, interesting... I would have guessed it was older still.
This PR updates the Chromium data for various Document API features that were initially implemented via the
HTMLDocument
alias, first by obtaining the version numbers via the mdn-bcd-collector project, then separating them into sections withpartial_implementation
. This is a cherry-pick from #6836, applying the review suggestions from #6836 (comment).