Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chrome data for Document features that were on HTMLDocument alias #6865

Merged
merged 10 commits into from
Oct 30, 2020

Conversation

queengooborg
Copy link
Contributor

This PR updates the Chromium data for various Document API features that were initially implemented via the HTMLDocument alias, first by obtaining the version numbers via the mdn-bcd-collector project, then separating them into sections with partial_implementation. This is a cherry-pick from #6836, applying the review suggestions from #6836 (comment).

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 8, 2020
queengooborg added a commit to queengooborg/browser-compat-data that referenced this pull request Oct 8, 2020
api/Document.json Outdated Show resolved Hide resolved
@foolip foolip requested a review from ddbeck October 9, 2020 11:43
@foolip
Copy link
Contributor

foolip commented Oct 9, 2020

@ddbeck I'd like your review on the note wording for this.

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notes look good to me now, the only issue I can spot now is the Opera Presto ranges, which can probably all be collapsed.

api/Document.json Show resolved Hide resolved
api/Document.json Outdated Show resolved Hide resolved
queengooborg and others added 3 commits October 21, 2020 20:56
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
api/Document.json Outdated Show resolved Hide resolved
@foolip
Copy link
Contributor

foolip commented Oct 29, 2020

Ping @vinyldarkscratch. If there's something tricky to resolve here, maybe we can split out those changes?

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done another lighter review, all looks good to me now!

"notes": "Starting in Chrome 65, this property is readonly."
},
{
"version_added": "3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document.all added in Chrome 3, interesting... I would have guessed it was older still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants