Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove never-supported CSS break-* features #6961

Merged
merged 3 commits into from
Nov 12, 2020

Conversation

saschanaz
Copy link
Contributor

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any: Remove items that has never been supported #6854, Remove totally unimplemented things #6768

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Oct 16, 2020
@rachelandrew
Copy link
Collaborator

So the always, recto and verso values should stay. Probably worth noting that fragmentation is something I believe is being improved in Blink with LayoutNG so maybe we will see support of these at some point.

Regions is an interesting one, as the Regions spec as is, will probably never be implemented. I think at some point Regions will be brought back, and will definitely rely on fragmentation just like multicol. However given we have no active implementations of the old spec now that Edge is based on Chromium there probably isn't a reason to keep this in our data right now.

So I think we could lose the Regions stuff, but keep the values as mentioned above.

@saschanaz
Copy link
Contributor Author

@rachelandrew Is always really a thing? It seems CSS Fragmentation Module does not define it. Somehow Gecko supports it saying that CSSWG resolved to add always but I can't confirm whether it is true.

@rachelandrew
Copy link
Collaborator

Moved to Fragmentation 4: https://drafts.csswg.org/css-break-4/#valdef-break-before-always

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit e150721 into mdn:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants